Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataGrid sorting #1690

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix DataGrid sorting #1690

merged 2 commits into from
Jun 26, 2024

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Jun 26, 2024

Fixes sorting for Mod Library and Completed Downloads section.

DataGridTemplateColumn needs SortMemberPath to know which property to use for sorting.
The ugly part is that it takes a string rather than a binding or something Type checkable.

@Al12rs Al12rs requested a review from a team June 26, 2024 12:14
@Al12rs Al12rs self-assigned this Jun 26, 2024
@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Jun 26, 2024
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@Al12rs Al12rs force-pushed the fix/datagrid-sorting branch from 39e320d to 567f69a Compare June 26, 2024 13:19
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Jun 26, 2024
@Al12rs Al12rs merged commit 7550468 into main Jun 26, 2024
11 checks passed
@Al12rs Al12rs deleted the fix/datagrid-sorting branch June 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

FileOriginView Sorting Is Broken
2 participants