Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #1700

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Update documentation #1700

merged 3 commits into from
Jul 1, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jun 27, 2024

Resolves #1669.

@erri120 erri120 requested a review from a team June 27, 2024 14:58
@erri120 erri120 self-assigned this Jun 27, 2024
MattSturgeon
MattSturgeon reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, but reading through the docs I've commented on some other lines that could do with some attention IMO.

docs/developers/Contributing.md Outdated Show resolved Hide resolved
docs/developers/Contributing.md Outdated Show resolved Hide resolved
docs/users/SystemRequirements.md Outdated Show resolved Hide resolved
@erri120
Copy link
Member Author

erri120 commented Jul 1, 2024

These changes look good, but reading through the docs I've commented on some other lines that could do with some attention IMO.

Thanks, will take a look.

@erri120 erri120 requested a review from MattSturgeon July 1, 2024 07:49
@erri120 erri120 merged commit 3e5f7e9 into Nexus-Mods:main Jul 1, 2024
3 checks passed
@erri120 erri120 deleted the docs/1669 branch July 1, 2024 08:59
MattSturgeon
MattSturgeon reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering my feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pickysaurus Pickysaurus Pickysaurus left review comments

@MattSturgeon MattSturgeon MattSturgeon left review comments

@Al12rs Al12rs Al12rs approved these changes

Assignees

@erri120 erri120

Labels
None yet
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve documentation for package maintainers
4 participants
@erri120 @MattSturgeon @Al12rs @Pickysaurus