-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move downloads out of Temp and clean up after cancel and complete #1704
Conversation
# Conflicts: # tests/Networking/NexusMods.Networking.Downloaders.Tests/DownloadServiceDataStoreTests.cs
src/Networking/NexusMods.Networking.Downloaders/DownloadService.cs
Outdated
Show resolved
Hide resolved
src/Networking/NexusMods.Networking.Downloaders/DownloadService.cs
Outdated
Show resolved
Hide resolved
src/Networking/NexusMods.Networking.Downloaders/DownloadService.cs
Outdated
Show resolved
Hide resolved
Need to look into the test not passing on windows |
I will change the tests to use a Setting override, since it should actually be better for running tests concurrently |
…ncurrency problems of switching base folder of the same service.
Used the setting override in the tests, tests pass locally and it doesn't seem like any files are left around after the test (the folder structure yes, but it is empty). |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1704 +/- ##
==========================================
- Coverage 42.15% 40.22% -1.93%
==========================================
Files 769 706 -63
Lines 26393 24873 -1520
Branches 1999 1885 -114
==========================================
- Hits 11126 10006 -1120
+ Misses 14895 14533 -362
+ Partials 372 334 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Ongoing download files are now stored next to DataModel folder, in Downloads/Ongoing.
Each download task will have a separate folder (guid name), which simplifies cleanup on download cancellation and download completion.
The base folder for the Downloads is determined by a setting, but it can be overruled through an internal method for testing purposes (so that each test has a different download base folder).