Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnrealEngine][PacificDrive] initial impl #1747

Closed
wants to merge 20 commits into from
Closed

[UnrealEngine][PacificDrive] initial impl #1747

wants to merge 20 commits into from

Conversation

ZeeWanderer
Copy link
Contributor

@ZeeWanderer ZeeWanderer commented Jul 10, 2024 •
edited
Loading

Not for merging, at least until the game support contributions are eventually accepted. As of the latest commit the game is managed as expected. I will try to keep it up to date with changes to the main repo.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@ZeeWanderer ZeeWanderer force-pushed the pacificdrive branch 2 times, most recently from 40ca738 to b6e8946 Compare August 3, 2024 10:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Aug 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Aug 6, 2024
@ZeeWanderer ZeeWanderer force-pushed the pacificdrive branch 3 times, most recently from 934a45d to cf856b2 Compare August 7, 2024 12:59
@ZeeWanderer ZeeWanderer force-pushed the pacificdrive branch 2 times, most recently from b09ee53 to cccacb6 Compare August 20, 2024 13:59
@ZeeWanderer ZeeWanderer mentioned this pull request Aug 20, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Aug 21, 2024
@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Dec 10, 2024
@halgari halgari added the status-not-ready This is not yet ready for development. Set by CI do not remove label Dec 17, 2024
@halgari
Copy link
Collaborator

halgari commented Dec 17, 2024

We're not ready to add this game to the app, we'll consider it later on

@halgari halgari closed this Dec 17, 2024
@ZeeWanderer
Copy link
Contributor Author

ZeeWanderer commented Mar 4, 2025 •
edited
Loading

Well, as I said before this is a draft for a time when you are ready to accept support for other games, and I opened the pr mostly to get notified when it conflicts with main to keep up to date so i know when to fix it. Sorry if it caused any problems

@Sewer56
Copy link
Member

Sewer56 commented Mar 4, 2025

Although it may not be my decision to make, I personally think you should keep the PR around.

I was quite sad when it got closed by another member of the team, because you knew the situation here full well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status-not-ready This is not yet ready for development. Set by CI do not remove
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeeWanderer @halgari @Sewer56