collection-cards #2059
Merged
collection-cards #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show known collections
|
Marking this ready to review. Not sure if people doing the styling will want to get that in before or after this gets merged. |
|
Clarification as it confused me. To access the new page, open a new tab in the workspace and select the WIP page from there. It does not appear in the left menu. |
Pickysaurus
added
the
Epic: Collections
erri120
requested changes
Sep 19, 2024
src/Abstractions/NexusMods.Abstractions.NexusModsLibrary/Models/Collection.cs
Outdated
Show resolved
Hide resolved
src/Abstractions/NexusMods.Abstractions.NexusModsLibrary/Models/Collection.cs
Outdated
Show resolved
Hide resolved
src/Abstractions/NexusMods.Abstractions.NexusModsLibrary/Models/Collection.cs
Outdated
Show resolved
Hide resolved
src/Abstractions/NexusMods.Abstractions.NexusModsLibrary/Models/CollectionRevision.cs
Outdated
Show resolved
Hide resolved
src/Abstractions/NexusMods.Abstractions.NexusModsLibrary/Models/CollectionRevision.cs
Outdated
Show resolved
Hide resolved
src/Abstractions/NexusMods.Abstractions.NexusModsLibrary/Models/CollectionRevision.cs
Outdated
Show resolved
Hide resolved
src/NexusMods.App.UI/Pages/LibraryPage/Collections/CollectionsViewModel.cs
Outdated
Show resolved
Hide resolved
We can do styling in a future PR |
erri120
reviewed
Sep 19, 2024
src/Abstractions/NexusMods.Abstractions.NexusModsLibrary/Models/CollectionRevision.cs
Outdated
Show resolved
Hide resolved
erri120
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough Draft of Collection Cards. The functionality is mostly here, but the styling needs some work. I'd done about all I can do as far as styling, and it's likely a waste of time to have me flounder on this much more.
Collections (WIP)that will eventually be rolled into the Library. For now it's easy enough to display it as a separate page so we don't have to feature flag itGetOrAddCollectionMetadatanow makes a single GQL call and loads and saves off both the collection image and the Users' avatar image.GetOrAddCollectionMetadatais idempotent on data that has not changed, so we can update that later to re-query the data as needed.0/12mod counts are not yet implementedTo Test:
Collections (WIP)pageYes it looks like trash...but the structure of the UI components should be correct, and we can change the styling.