Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling bug fixes for TreeDataGrid #2060

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Styling bug fixes for TreeDataGrid #2060

merged 11 commits into from
Sep 19, 2024

Conversation

insomnious
Copy link
Collaborator

@insomnious insomnious commented Sep 19, 2024

Styling bugs fixed:

  • Expander chevrons now have hover states and correctly sized
  • Compact class for TreeDataGrid with narrower rows
  • Get Advanced Installer back in line with Figma
  • Status bar on Preview Changes no longer above the tree

Advanced Installer changes really are enough to be getting on and don't exactly meet how we do the other controls (styling where it ideally shouldn't be etc.). To take this further would be too much refactoring at this time. We will come back around to advanced installer at some point.

@insomnious insomnious self-assigned this Sep 19, 2024
@insomnious insomnious marked this pull request as ready for review September 19, 2024 07:52
@Al12rs Al12rs self-requested a review September 19, 2024 12:01
Copy link
Collaborator

@captainsandypants captainsandypants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Al12rs Al12rs merged commit 0df4f73 into main Sep 19, 2024
11 checks passed
@Al12rs Al12rs deleted the treeview-styling-2 branch September 19, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants