Update to the new version of MnemonicDB #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repo before this works
erri120
reviewed
Sep 21, 2024
Comment on lines
5
to
21
| public abstract class ThreeWayMerger<TA, TB, TC, TOut> | ||
| where TA : notnull | ||
| where TB : notnull | ||
| where TC : notnull | ||
| { | ||
| public abstract int CompareAB(TA a, TB b); | ||
| public abstract int CompareAC(TA a, TC c); | ||
| public abstract int CompareBC(TB b, TC c); | ||
|
|
||
| public abstract TOut Combine(Optional<TA> a, Optional<TB> b, Optional<TC> c); | ||
|
|
||
| public void Merge(IEnumerable<TA> aColl, IEnumerable<TB> bColl, IEnumerable<TC> cColl) | ||
| { | ||
|
|
||
| } | ||
|
|
||
| } |
erri120
approved these changes
Sep 23, 2024
insomnious
added a commit
that referenced
this pull request
Sep 24, 2024
Revert "Update to the new version of MnemonicDB (#2064)" to fix App locking up issue
halgari
added a commit
that referenced
this pull request
Oct 1, 2024
* Update to the new MnemonicDB API, still needs a fix in the MnemonicDB repo before this works * Fix tuple remapping * Try and fix the package reference errors (someday I should read up on how this works) * Not sure why this existed * Fix sorting error on RedModInstallerTests by sorting the data we hand to Verify * cleanup the project file a bit * Update to the newest version of MnemonicDB so that we can fix the deadlock issue introduced in the previous version --------- Co-authored-by: halgari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much a nothing PR. The recent internal changes to MnemonicDB split the AttributeRegistry into two distinct parts:
IAttributeclass based on an AttributeId. This class is created and maintained by theIConnectionThis change makes most of MnemonicDB free from any sort of global context or DI. Datoms are inserted into transactions and the backend store serves up
Datom, all the mapping to and from C# objects happens outside of the MnemonicDB internalsAll that to say, about 40 places in the code needed a class name change, and few places needed some small changes.