New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3/4] Improve: Small Cleanup / Tech Debt Reduction Around NexusWebApi / V2 Types. #2095

Merged

halgari merged 23 commits into main from start-adding-v2-types

Oct 3, 2024

Member

Sewer56 commented Sep 26, 2024 •

edited

Loading

This is 3rd PR in chain. Continues from:

[2/4] Added: Caching system for updates. #2092

Should be merged after that PR, this will reduce the diff from main to only changed parts.

Next in chain (final PR):

[4/4] Query for Updates from Nexus, and Fix Miscellaneous Bugs in DataStore #2113

Review final PR if you want to review all parts at once, else review them by parts sequentially.

Also contributes a bit towards:

Switch to GQL for all Nexus Mods queries (or the ones we can) #2091 (comment)

Summary

This PR moves the types from

[2/4] Added: Caching system for updates. #2092

Into the mainline NexusWebApi abstractions project.
I refrained from doing that in #2092 because it would make PR reviewing very annoying.

In addition some work is done to help migration towards the V2 API.

Changelog

ModUpdates project now uses types in NexusWebApi abstractions.
Types which are confirmed to exist in V2 (GraphQL) API are placed in a V2 folder to prevent accidental future deletion when getting rid of REST APIs.
The structs ModId, FileId, GameId now use the correct field size (u32)
- They are not u64 like in our previous definition. This has been verified with both backend and GraphQL documentation.
Implemented UidForFile and UidForMod.
- These allow us to split up UID composite keys returned from the website into their specific components, (GameId+ ModId) or (GameId+FileId).
- Methods to decode strings in V2 API results into Uid variants are provided.

Sewer56 added 14 commits

September 19, 2024 02:39


          WIP: Documentation for Update Detection

78ace0f


          Added: Additional Edge Cases to Update Logic Docs

796c123


          Added: Extra case of Archived in the Middle

0cfb392


          Fixed: Indentation for file_updates field.


          Finalized 'Updating Mods' doc with simplified Implementation requested.

600ec0b


          Fixed: Minor Notes from older Research Doc


          Merge branch 'main' into detect-updates-docs-only

d151e86


          Fixed: Added Missing 'Updating Mods' mkdocs sidebar item.

b54efac


          [Working WIP] Added: Initial Implementation of Generic Page Caching S…

71a131b

…ystem used by Mod Pages


          Merge remote-tracking branch 'origin/main' into updates-cache-system

6fe3105


          Tech Debt Reduction: Add additional V2 GraphQL Types and Correct Size…

7afd32d

…s of Existing Types


          Added: Missing 'UInt32' types in attribute definitions


          Improved: Accuracy of documentation for FileId struct.

3eb2986


          Added: Method for constructing UidForMod and UidForFile from GraphQL …

2de875a

…API Results

Sewer56 added the Epic: Tech-debt label

Sewer56 requested a review from a team

September 26, 2024 06:18

Sewer56 self-assigned this

Sewer56 mentioned this pull request

[2/4] Added: Caching system for updates. #2092

Merged


          Rename: ICanGetUid to ICanGetUidForMod

a0d80d4

halgari approved these changes

View reviewed changes

tests/Networking/NexusMods.Networking.ModUpdates.Tests/Tests.cs Outdated Show resolved Hide resolved

src/Abstractions/NexusMods.Abstractions.NexusWebApi/Types/V2/Uid/UidForFile.cs Show resolved Hide resolved

halgari previously requested changes

View reviewed changes

Collaborator

halgari left a comment

Didn't mean to approve it above

Sewer56 added 3 commits

September 27, 2024 02:02


          Added: Tests for UidForModTests and UidForFileTests

e8e09e3


          Removed: Unused Tests.cs file

e4349be


          Merge branch 'updates-cache-system' into start-adding-v2-types

2c96668

github-actions bot added the status-needs-rebase label

Contributor

github-actions bot commented Sep 30, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

github-actions bot removed the status-needs-rebase label

Contributor

github-actions bot commented Sep 30, 2024

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

Sewer56 force-pushed the start-adding-v2-types branch from 22bc785 to 2c96668 Compare

September 30, 2024 12:56

Contributor

github-actions bot commented Sep 30, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

github-actions bot added status-needs-rebase and removed status-needs-rebase labels

Contributor

github-actions bot commented Sep 30, 2024

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.


          Merge branch 'main' into start-adding-v2-types

dbd6d20

Sewer56 force-pushed the start-adding-v2-types branch from f8b190b to dbd6d20 Compare

September 30, 2024 13:04


          Merge branch 'main' into start-adding-v2-types

731a620

github-actions bot added the status-needs-rebase label

Contributor

github-actions bot commented Oct 1, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.


          Merge remote-tracking branch 'origin/main' into start-adding-v2-types

edf3775

Contributor

github-actions bot commented Oct 2, 2024

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

github-actions bot removed the status-needs-rebase label

Sewer56 changed the title ~~Improve: Small Cleanup / Tech Debt Reduction Around NexusWebApi / V2 Types.~~ [3/4] Improve: Small Cleanup / Tech Debt Reduction Around NexusWebApi / V2 Types.

github-actions bot added the status-needs-rebase label

Contributor

github-actions bot commented Oct 2, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.


          Merge branch 'main' into start-adding-v2-types

a68e6dd

Contributor

github-actions bot commented Oct 2, 2024

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

github-actions bot removed the status-needs-rebase label

Sewer56 mentioned this pull request

[4/4] Query for Updates from Nexus, and Fix Miscellaneous Bugs in DataStore #2113

Merged

halgari dismissed their stale review

October 3, 2024 15:50

changes were made as requested


          Merge branch 'main' into start-adding-v2-types

# Conflicts:
#	src/Networking/NexusMods.Networking.ModUpdates/MultiFeedCacheUpdater.cs
#	src/Networking/NexusMods.Networking.ModUpdates/NexusMods.Networking.ModUpdates.csproj
#	src/Networking/NexusMods.Networking.ModUpdates/PerFeedCacheUpdater.cs
#	src/Networking/NexusMods.Networking.ModUpdates/PerFeedCacheUpdaterResult.cs
#	tests/Networking/NexusMods.Networking.ModUpdates.Tests/Helpers/TestItem.cs
#	tests/Networking/NexusMods.Networking.ModUpdates.Tests/MultiFeedCacheUpdaterTests.cs
#	tests/Networking/NexusMods.Networking.ModUpdates.Tests/PerFeedCacheUpdaterTests.cs

github-actions bot added the status-needs-rebase label

Contributor

github-actions bot commented Oct 3, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

Contributor

github-actions bot commented Oct 3, 2024

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

github-actions bot removed the status-needs-rebase label

halgari merged commit d09d737 into main

12 checks passed

halgari deleted the start-adding-v2-types branch

October 3, 2024 15:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Epic: Tech-debt