Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find GOG games installed with the Heroic launcher #2103

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Sep 28, 2024

Part of #1695.

There is an issue with running the game through heroic, as heroic never exists. We'll probably want to track WINE.

Part of Nexus-Mods#1695. This only finds the games, we still need a way to run
them through the launcher.
@erri120 erri120 requested a review from a team September 28, 2024 12:57
@erri120 erri120 self-assigned this Sep 28, 2024
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but I didn't try it out. If the changes in game finder are unlikely to introduce regressions we can go ahead an merge.

@erri120 erri120 merged commit 7e795ca into Nexus-Mods:main Sep 30, 2024
12 checks passed
@erri120 erri120 deleted the heroic branch September 30, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants