Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Uninstall Experience #2114

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Improved: Uninstall Experience #2114

merged 2 commits into from
Oct 2, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Oct 2, 2024

This PR makes a slight improvement to the uninstall experience.

  1. Disables GC when unmanaging game during uninstall, as it's not needed, since the uninstaller will wipe the archives anyway.
  2. Deletes the Downloads folder during the uninstall procedure.

Currently trying to reproduce the uninstall issue, I cannot either on Linux or Windows at the moment. So this PR should also serve me CI builds to get installer.

@Sewer56 Sewer56 added the Bug Something isn't working label Oct 2, 2024
@Sewer56 Sewer56 self-assigned this Oct 2, 2024
@Sewer56 Sewer56 requested a review from a team October 2, 2024 06:37
@Sewer56 Sewer56 merged commit 74ae525 into main Oct 2, 2024
10 checks passed
@erri120 erri120 deleted the fix-uninstall branch October 2, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants