Improved: Additional Set of Uninstaller Improvements #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata folder (NexusMods.App), in addition to used directories from config
Sewer56
changed the title
Al12rs
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Remove Local Application Data
Very tiny patch.
Up until now, the uninstaller has been focusing on all locations defined within the App's config files; this is because it has historically been possible to re-route these to different locations on disk via various config knobs.
However, that leaves the base NMA folder stranded on the FileSystem, which means that users will get an unwanted prompt on re-install:
This PR adds the 'Local Application Data' directory as one of the targets to wipe, ensuring no folders are left behind.
Fix: Fix Windows Uninstall when App Location has Spaces
Uninstall on Windows now works if the path to the Application folder has spaces in it.
The path to the PowerShell script wasn't escaped properly, PS has rules for nested escapes, and that wasn't being handled properly.
Fix: Remove Waiting Workaround from Old DataModel Bug
See deleted lines. We used to have a concurrency bug with
IRepository, but that's been fixed since.