Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial framework for FalloutNV #2127

Closed
wants to merge 17 commits into from

Conversation

MistaOmega
Copy link
Contributor

@MistaOmega MistaOmega commented Oct 4, 2024

I hope I've followed the usual structure of game addition here, I've referred to the docs so I think I've covered everything I need

With that said:
Relates to #38

Covers Steam, Epic, Xbox and GOG, (I've tested Epic and Steam)

A few things need resolving, hoping some people can help:

  1. I'm missing the GOG id, on account of I don't own the GOG version
  2. Epic and Xbox support all 5 languages as separate installs, I need to modify the GetPrimaryFile to recognize the correct subfolder
  3. Need confirmation if you want this under namespace obsidian, or if I create one for BGS games, due to the similarities it shares with BGS games
  4. Booting the game defaults to the launcher and ONLY works when installed on the C drive, otherwise there's an error booting 5:0000065434 -- A steam.dll related error I think
  5. The enabled mod ESPs need enabling within data files from the launcher before playing. (just needs the plugins.txt updating I think? looking into this still) Q: Is this part of the synchronisation process?

Tested with the following mods

  • JIP LN NVSE
  • ShowOff xNVSE
  • JohnnyGuitar NVSE
  • B42 Dropmag
  • A Familiar Friend - Pip Boy 2500 - Handheld Pipboy
  • Weapon Animation Replacers FOMOD (to test the FOMOD xml processing)
  • NVSE, using the installer not at all based on the BG3SEInstaller

That covers most of the basic types of mod I think
Note I couldn't install things like the MCM due to it being part of a .fomod extension, which I think we don't yet support

@MistaOmega MistaOmega marked this pull request as draft October 4, 2024 12:30
@MistaOmega MistaOmega marked this pull request as ready for review October 4, 2024 18:14
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Oct 10, 2024
# Conflicts:
#	src/Abstractions/NexusMods.Abstractions.NexusWebApi/Types/V2/GameId.cs
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Oct 10, 2024
@Pickysaurus
Copy link
Contributor

Hi @MistaOmega,

Thank you for your contribution.

I would first like to apologise for your PR not being acknowledged sooner.

While what you have here looks cool and would be a decent start to supporting Fallout New Vegas, we're not currently accepting community pull requests for game support - particularly for the core games on the website.

We plan to tackle support for Bethesda games in-house as an upcoming project (roadmap). When we get to that point we'd love for you to be involved in the process. It is expected we'll start looking into Bethesda game support towards the end of this year. Right now, we're focused on adding the core app features we'll need (e.g. load order, conflict detection, mod updates) to better support these games.

Thank you again for your contribution and your enthusiasm for our app!

@Pickysaurus Pickysaurus added the BLOCKED This ticket cannot be completed until another ticket is completed label Oct 16, 2024
@halgari
Copy link
Collaborator

halgari commented Oct 21, 2024

To be clear on this, we are doing a big spike on Bethesda game support starting next year. Until then we'll probably hold off on adding FalloutNV support. Bethesda games are fairly complex and we want to implement them one at a time in order to make sure we get the fundamentals solidified. Most likely the order will be SkyrimSE->Fallout4->Starfield->FalloutNV/3.

I won't close this down, but just be aware that we'll likely ignore this PR and it'll probably get out-of-sync with the main repo once we add support for other games and features.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

@halgari
Copy link
Collaborator

halgari commented Dec 17, 2024

Closing as per the above conversation

@halgari halgari closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED This ticket cannot be completed until another ticket is completed status-needs-rebase Set by CI do not remove User Raised
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants