Remove IImageCache
#2391
Merged
Remove IImageCache
#2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sewer56
reviewed
Dec 16, 2024
| { | ||
| try | ||
| { | ||
| if (optionImage.TryPickT0(out var uri, out var imageStoredFile)) |
There was a problem hiding this comment.
This is technically not incorrect, but it 'feels' a bit weird. Technically you should prefer loading a local file, so you really should be asking 'do I have a local file' instead of 'do I have a URL'.
While in this case there isn't a functional difference, because it's a OneOf; I thought I'd point it out. Someone looking at this code may misinterpret it; since the Try methods in a branch like this are usually used with dictionaries. I had to double take, until I saw it was a OneOf
Consider flipping the condition, i.e. TryPickT1
There was a problem hiding this comment.
I've simplified the code using Match.
Sewer56
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.