Fixing the flaky test #2395
Merged
Fixing the flaky test #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've ran CI twice on this PR and both runs succeeded, not sure if the issue is 100% fixed. |
|
This might actually work, because IIRC on .net runners the temp folder is sometimes on a ramdisk and acts strangely. That might be some of the issue here |
halgari
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #2394.
Since the error we're getting back is
No such file or directoryon amkdiroperation, it's possible that parts of the path get deleted for whatever reason. Instead of putting the temp files into/home/runner/.local/, this PR changes the temp path to be inside the repo. Maybe GitHub runners do weird stuff to outside files or something...