Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Check redesign #2397

Merged
merged 29 commits into from
Jan 6, 2025
Merged

Health Check redesign #2397

merged 29 commits into from
Jan 6, 2025

Conversation

insomnious
Copy link
Collaborator

Closes #2382

Gets Health Check up to date with Figma including new brand pictogram, subtab control and mutliline health check entries.

Doesn't include tweaking the left hand menu styles as that's a future task.

@insomnious insomnious requested a review from a team December 17, 2024 13:27
@insomnious insomnious self-assigned this Dec 17, 2024
@insomnious insomnious changed the title WIP Healthcheck redesign Health Check redesign Dec 17, 2024
@insomnious insomnious marked this pull request as ready for review December 17, 2024 13:27
Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Dec 19, 2024
@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Dec 19, 2024
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@Pickysaurus
Copy link
Contributor

@insomnious Not sure if it's in scope with what you're doing here, but this would be handy and a (hopefully) small tweak. #2418

@insomnious insomnious requested a review from erri120 January 6, 2025 09:47
@Al12rs Al12rs closed this Jan 6, 2025
@Al12rs Al12rs reopened this Jan 6, 2025
@Al12rs
Copy link
Contributor

Al12rs commented Jan 6, 2025

Closed and reopened to rebase CI merge builds onto latest main

@insomnious insomnious merged commit 8fff44d into main Jan 6, 2025
12 checks passed
@insomnious insomnious deleted the healthcheck-redesign branch January 6, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Health check design improvement
4 participants