Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOG file hashing #2407

Merged
merged 63 commits into from
Jan 16, 2025
Merged

GOG file hashing #2407

merged 63 commits into from
Jan 16, 2025

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Dec 17, 2024 •
edited
Loading

This PR adds the following:

  • it's now possible to log into GOG via OAuth
  • via a CLI command we can export product info about a game, including hashes
  • we're able to get the build, depot and hash values
  • also possible to get a seekable read-only stream to these files
  • Updates the Proxy Renderer to support progress bars in the console
  • Fixes the seekable chunked stream reader so that it supports chunks of arbitrary sizes (previously all blocks had to be the same size)

halgari and others added 30 commits December 11, 2024 10:12
@halgari
Basic structure of the projects, can login via a test, and stay logge…
47595e6 
…d in
@halgari
Implemented the rest of the Steam flow for getting manifests. Introdu…
669d794 
…ced a .Hashes abstraction library for hash value types. Moved Chunked streams into the IO abstractions library
@halgari
Boom, can stream files off of Steam
f52f6a9
@halgari
Can download files, serialize manifests, all that good stuff
c6d7703
@halgari
Fix the chunked stream so that it can use arbitrarily sized chunks
49b3d9c
@halgari
Delete the old Store project
c90d121
@halgari
Disable the test that has to be run with human interaction
eb32afd
@halgari
Few more comments and cleanup
ed8f39f
@halgari
WIP, can mostly log into GOG at this point
9d03f7b
@halgari
Can log into GOG and get product info, the format for the files thems…
5e944e6 
…elves is rather whack, but we can make it work
@halgari @erri120
Update Abstractions/NexusMods.Abstractions.Steam/DTOs/ProductInfo.cs
d64c215 
Co-authored-by: erri120 <[email protected]>
@halgari @erri120
Update src/Abstractions/NexusMods.Abstractions.Hashes/Crc32.cs
f734e43 
Co-authored-by: erri120 <[email protected]>
@halgari @erri120
Update src/Networking/NexusMods.Networking.Steam/NexusMods.Networking…
b58d349 
….Steam.csproj

Co-authored-by: erri120 <[email protected]>
@halgari @erri120
Update src/Networking/NexusMods.Networking.Steam/Session.cs
05e5f85 
Co-authored-by: erri120 <[email protected]>
@halgari @erri120
Update Abstractions/NexusMods.Abstractions.Steam/DTOs/Manifest.cs
0c20eb3 
Co-authored-by: erri120 <[email protected]>
@halgari @erri120
Update src/Networking/NexusMods.Networking.Steam/ProductInfoParser.cs
fd26dc2 
Co-authored-by: erri120 <[email protected]>
@halgari @erri120
Update src/Abstractions/NexusMods.Abstractions.Hashes/MultiHasher.cs
869a959 
Co-authored-by: erri120 <[email protected]>
@halgari @erri120
Update src/Networking/NexusMods.Networking.Steam/Session.cs
752486b 
Co-authored-by: erri120 <[email protected]>
@halgari
WIP getting access to files
3075e76
@halgari
sizeof(ulong) vs size(long)
6815ce4
@halgari
Update doc strings to better explain the value sizes
f6e59ce
@halgari
Downloading and basic indexing of GOG data
6b7bc9a
@halgari
Can hash depots and export data, and it's not horrible performance
20d79bb
@halgari @erri120
Update src/Networking/NexusMods.Networking.Steam/ManifestParser.cs
782c74f 
Co-authored-by: erri120 <[email protected]>
@halgari
Export all OSes
62cbbfd
@halgari @erri120
Update src/Abstractions/NexusMods.Abstractions.Hashes/HashJsonConvert…
a5dd382 
…er.cs

Co-authored-by: erri120 <[email protected]>
@halgari
Fix the .Steam project
6cca217
@halgari
Merge branch 'steam-login' of https://github.com/Nexus-Mods/NexusMods…
71c769a 
….App into steam-login
@halgari
fix compile errors introduced during code review
f2b3e6b
@halgari
Upgrade deps, fix several broken tests on main
d24b52b
@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@halgari
Copy link
Collaborator Author

halgari commented Jan 14, 2025

@erri120 @Al12rs @Sewer56 ready for a review, browser stuff is gone.

@erri120 erri120 requested a review from a team January 15, 2025 11:37
@Al12rs Al12rs requested review from Al12rs and removed request for erri120 January 15, 2025 13:18
Al12rs
Al12rs requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of questions and potentially some suggestions/improvements above

src/Abstractions/NexusMods.Abstractions.GOG/DTOs/Build.cs Outdated Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.GOG/Values/DepotItemType.cs Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.GOG/Values/OS.cs Outdated Show resolved Hide resolved
src/Abstractions/NexusMods.Abstractions.IO/SubStream.cs Show resolved Hide resolved
src/NexusMods.ProxyConsole/SpectreRenderer.cs Outdated Show resolved Hide resolved
src/Networking/NexusMods.Networking.GOG/Models/AuthInfo.cs Show resolved Hide resolved
src/Networking/NexusMods.Networking.GOG/Client.cs Outdated Show resolved Hide resolved
src/Networking/NexusMods.Networking.GOG/Client.cs Outdated Show resolved Hide resolved
src/Networking/NexusMods.Networking.GOG/Client.cs Show resolved Hide resolved
@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR conflicts with main. You need to rebase the PR before it can be merged.

@github-actions GitHub Actions
Copy link
Contributor

This PR doesn't conflict with main anymore. It can be merged after all status checks have passed and it has been reviewed.

@github-actions github-actions bot removed the status-needs-rebase Set by CI do not remove label Jan 16, 2025
@halgari halgari requested a review from Al12rs January 16, 2025 14:11
@halgari halgari merged commit ca81f4d into main Jan 16, 2025
12 checks passed
@halgari halgari deleted the gog-login branch January 16, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs approved these changes

Assignees

@halgari halgari

Labels
None yet
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@halgari @Sewer56 @erri120 @Al12rs