Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes lack of Library scrolling #2484

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Fixes lack of Library scrolling #2484

merged 3 commits into from
Jan 20, 2025

Conversation

insomnious
Copy link
Collaborator

Added ScrollViewer for whole page as per @captainsandypants request. Added bottom border to expanders to visually separate when both are collapsed.

@insomnious insomnious requested a review from Sewer56 January 15, 2025 15:53
@insomnious insomnious self-assigned this Jan 15, 2025
@Al12rs
Copy link
Contributor

Al12rs commented Jan 16, 2025

This makes it so the entire page contents are scrolled rather than just the contents of the TreeDataGrid:
image

While in the loadout the headers of the treedatagrid stay in view:
image

@Sewer56
Copy link
Member

Sewer56 commented Jan 16, 2025

@Al12rs

I noted that internally yesterday, there's a discussion thread about it.
@insomnious 's going to discuss more with @captainsandypants later.

So check there if looking for more context/chat/talk.

@Al12rs
Copy link
Contributor

Al12rs commented Jan 16, 2025

To make it work with just the Tree scrolling and keeping the header in view (you have to collapse the collections section to make room to actually see of course), you can remove the ScrollViewer at the top, replace the top StackPanel with a <Grid RowDefinitions="Auto, *">, and that should just work.

image

image

@Sewer56
Copy link
Member

Sewer56 commented Jan 16, 2025

Oh, that actually worked for you?

It was the literal first thing I tried yesterday, and I didn't have as good luck; maybe I missed something in there given I've only poked around for 15 minutes.

@insomnious
Copy link
Collaborator Author

I also tried that first and it doesn't work in all eventualities. We don't need 3 people on this so don't worry about it for now as I'm going through with Laurence some different options to get us through to the milestone. As was discussed on Slack.

@Sewer56
Copy link
Member

Sewer56 commented Jan 16, 2025

@insomnious

Please delete the above comment and remove the name of the chat application before reposting. If you don't, @ erri120 will, as they usually do.

@insomnious
Copy link
Collaborator Author

Removed page-wide vertical scroll
Moved EmptyState for mods so it stays within the expander but doesn't show the toolbar.
Fixed height on Collections expander content
Signed off by @captainsandypants

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TreeDataGrid seems to be virtualizing the items correctly

@Al12rs Al12rs merged commit b4b0648 into main Jan 20, 2025
11 checks passed
@Al12rs Al12rs deleted the fix-library-scrollbar branch January 20, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants