-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Updater #546
App Updater #546
Conversation
* Cleanup FOMOD * Add dummy implementations * Cleanup
) * Fix cli verbs ignoring the passed modName. Fix NxmDownloadProtocolHandler ignoring passed modName. # Conflicts: # src/NexusMods.CLI/Verbs/DownloadAndInstallMod.cs * Add final check for ModManagementVerb tests * Make AVerbTest public so it can be used in other tests * Add SkyrimLegendary edition end to end tests for milestone 1. - Installs SKSE, Skyui, USLEP and check if everything went well. * Add milestone one tests for SkrimSpecialEdition - Install SKSE64, Skyui, USSEP and check if everything went well - Some code formatting * Fix build * Use const
* Configure INI parser to support bethesda ini files. Configuration taken from Mutagen: https://github.com/Noggog/Mutagen/blob/369a0549fab90593cb130b3889f988228f8ecf98/Mutagen.Bethesda.Core/Archives/DI/GetArchiveIniListings.cs#L38-L46 * Add test for INI parsing
Remove duplicated code
This PR conflicts with |
This PR doesn't conflict with |
Some things to note: the updater should fetch the correct release asset, depending on the |
This PR conflicts with |
I had a look over the code; I have nothing else to add other than what @erri120 already said above. Edit: More specifically: Some packaging systems for applications (e.g. AppImage) treat the application itself as read-only, and would therefore not be able to utilise the updater. |
Why would we want inno setup involved on updates just because the original version was installed that way? I don't know enough about Flatpack to comment on that, but with Windows I don't think we want to download and run inno setup for updates. |
After reviewing this with the team, we're going to go down a different route of showing a dialog and instructing users where to go to update the app themselves |
First steps of the app updater, disabled in the code, but the main parts can be run from the CLI and the unit tests can be run. Description of the service can be found here: https://github.com/Nexus-Mods/NexusMods.App/pull/546/files?short_path=d82896c#diff-d82896c18eb5f8f050e974d17f1209f8e859c7b6a069ab38b0e9ee1513b88ba7
After this is in, I'll release a v0.2.1 version of the app with this included, and then we can test the end-to-end process of updating.