Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Testing rework #809

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Workspace Testing rework #809

merged 10 commits into from
Dec 7, 2023

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Dec 7, 2023

Related to #674 and #791.

Changes:

  • Reworked the GridUtils tests.
  • Added WorkspaceGridState and PanelGridState to make it easier to work with the current state.
  • Added IsPerfectGrid and additional checks to make sure the code does what it's supposed to do.

@erri120 erri120 added the Epic: Tech-debt Technical debt, this needs solving in the long-term label Dec 7, 2023
@erri120 erri120 requested a review from Al12rs December 7, 2023 10:46
@erri120 erri120 self-assigned this Dec 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #809 (e098c00) into main (c9dcc7a) will increase coverage by 0.77%.
Report is 2 commits behind head on main.
The diff coverage is 69.39%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   60.29%   61.06%   +0.77%     
==========================================
  Files         613      615       +2     
  Lines       18641    18786     +145     
  Branches     1339     1358      +19     
==========================================
+ Hits        11239    11472     +233     
+ Misses       7054     6967      -87     
+ Partials      348      347       -1     
Flag Coverage Δ
Linux 60.36% <69.39%> (+0.07%) ⬆️
Windows 60.26% <69.39%> (∅)
clean_environment_tests 61.04% <69.39%> (+0.75%) ⬆️
network_tests ?
networking_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...NexusMods.App.UI/WorkspaceSystem/PanelGridState.cs 100.00% <100.00%> (ø)
...UI/WorkspaceSystem/Workspace/WorkspaceViewModel.cs 0.00% <0.00%> (ø)
src/NexusMods.App.UI/WorkspaceSystem/GridUtils.cs 92.41% <78.72%> (-0.01%) ⬇️
...sMods.App.UI/WorkspaceSystem/WorkspaceGridState.cs 65.28% <65.28%> (ø)

... and 33 files with indirect coverage changes

@Al12rs Al12rs merged commit 17bf70e into Nexus-Mods:main Dec 7, 2023
3 checks passed
@erri120 erri120 deleted the workspace-cleanup branch December 7, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Tech-debt Technical debt, this needs solving in the long-term
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants