Fixes for various crashes while managing and running games (#758)
1022 new problems found by Qodana for .NET
Qodana for .NET
1022 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Possible null reference assignment. |
🔴 Failure | 2 |
Redundant using directive |
🔶 Warning | 66 |
Use of obsolete symbol |
🔶 Warning | 58 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 21 |
Redundant 'partial' modifier on type declaration |
🔶 Warning | 19 |
Unused parameter (private accessibility) |
🔶 Warning | 19 |
Namespace does not correspond to file location |
🔶 Warning | 18 |
Redundant namespace alias |
🔶 Warning | 12 |
Resource is not overridden in specific culture |
🔶 Warning | 8 |
Redundant member initializer |
🔶 Warning | 8 |
Async function without await expression |
🔶 Warning | 7 |
Variable in local function hides variable from outer scope |
🔶 Warning | 7 |
XML comment has a 'param' tag for 'Parameter', but there is no parameter by that name |
🔶 Warning | 6 |
Non-accessed field (private accessibility) |
🔶 Warning | 6 |
Unused local variable |
🔶 Warning | 6 |
Parameter has no matching param tag in the XML comment |
🔶 Warning | 5 |
Add/remove 'this.' qualifier |
🔶 Warning | 4 |
Function is recursive on all execution paths |
🔶 Warning | 4 |
Private field can be converted into local variable |
🔶 Warning | 4 |
Redundant nullable warning suppression expression |
🔶 Warning | 4 |
Invalid XML documentation comment |
🔶 Warning | 2 |
Redundant type arguments of method |
🔶 Warning | 2 |
Static member initializer refers to static member below or in other part |
🔶 Warning | 2 |
Code is unreachable |
🔶 Warning | 1 |
Cannot resolve reference in XML comment |
🔶 Warning | 1 |
Empty namespace declaration |
🔶 Warning | 1 |
Usage of <inheritdoc /> is invalid |
🔶 Warning | 1 |
Possibly impure struct method is called on readonly variable: struct value always copied before invocation |
🔶 Warning | 1 |
Assignment is not used |
🔶 Warning | 1 |
Redundant class or interface specification in base types list |
🔶 Warning | 1 |
Redundant 'WithCancellation()' invocation |
🔶 Warning | 1 |
Use preferred 'var' style (for built-in types) |
🔶 Warning | 1 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 1 |
Type member is never used (private accessibility) |
🔶 Warning | 1 |
Virtual member call in constructor |
🔶 Warning | 1 |
Style class not found |
◽️ Notice | 148 |
Type member is never used (non-private accessibility) |
◽️ Notice | 74 |
Auto-property can be made get-only (non-private accessibility) |
◽️ Notice | 70 |
Class is never instantiated (non-private accessibility) |
◽️ Notice | 66 |
Use preferred style for trailing comma before new line in multiline lists |
◽️ Notice | 53 |
Member can be made private (non-private accessibility) |
◽️ Notice | 48 |
Type member is never accessed via base type (non-private accessibility) |
◽️ Notice | 42 |
Redundant empty argument list on object creation expression |
◽️ Notice | 24 |
Invert 'if' statement to reduce nesting |
◽️ Notice | 17 |
Member can be made static (shared) (private accessibility) |
◽️ Notice | 13 |
Resource is overridden with identical value |
◽️ Notice | 10 |
Property can be made init-only (non-private accessibility) |
◽️ Notice | 10 |
Parameter can be declared with the base type |
◽️ Notice | 10 |
'if-return' statement can be rewritten as 'return' statement |
◽️ Notice | 9 |
Loop can be converted into LINQ-expression |
◽️ Notice | 9 |
Type is never used (non-private accessibility) |
◽️ Notice | 9 |
Field can be made readonly (private accessibility) |
◽️ Notice | 8 |
Unused parameter (non-private accessibility) |
◽️ Notice | 8 |
Convert 'if' statement into 'switch' |
◽️ Notice | 6 |
Member can be made protected (non-private accessibility) |
◽️ Notice | 6 |
Put local function after 'return' or 'continue' |
◽️ Notice | 5 |
Redundant 'else' keyword |
◽️ Notice | 5 |
Replace auto-property with computed property |
◽️ Notice | 5 |
Use preferred style of 'new' expression when created type is evident |
◽️ Notice | 4 |
Use explicit or implicit modifier definition for type members |
◽️ Notice | 4 |
Replace built-in type reference with a CLR type name or a keyword in static member access expressions |
◽️ Notice | 4 |
Method return value is never used (non-private accessibility) |
◽️ Notice | 4 |
Remove redundant parentheses |
◽️ Notice | 3 |
Use explicit or implicit modifier definition for types |
◽️ Notice | 3 |
Parameter type can be IEnumerable<T> (private accessibility) |
◽️ Notice | 3 |
Type parameter could be declared as covariant or contravariant |
◽️ Notice | 3 |
Convert negated 'is' expression into 'is' expression with negated pattern |
◽️ Notice | 3 |
Use preferred style of 'new' expression when created type is not evident |
◽️ Notice | 2 |
Class with virtual (overridable) members never inherited (non-private accessibility) |
◽️ Notice | 2 |
Convert constructor into member initializers |
◽️ Notice | 2 |
Convert property into auto-property (when possible) |
◽️ Notice | 2 |
Foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used |
◽️ Notice | 2 |
Use discard assignment |
◽️ Notice | 2 |
Use preferred namespace body style |
◽️ Notice | 1 |
'if' statement can be rewritten as '?:' expression |
◽️ Notice | 1 |
Replace 'switch' statement with 'switch' expression |
◽️ Notice | 1 |
Field can be made readonly (non-private accessibility) |
◽️ Notice | 1 |
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used |
◽️ Notice | 1 |
Inline temporary variable |
◽️ Notice | 1 |
Merge null/pattern/value checks into 'or'/'and' patterns |
◽️ Notice | 1 |
Make constructor in abstract class protected |
◽️ Notice | 1 |
Redundant [AttributeUsage] attribute property assignment |
◽️ Notice | 1 |
Redundant semicolon after type or namespace declaration |
◽️ Notice | 1 |
Redundant lambda signature parentheses |
◽️ Notice | 1 |
Replace 'Substring' with range indexer |
◽️ Notice | 1 |
Return type can be IEnumerable<T> (non-private accessibility) |
◽️ Notice | 1 |
Return type can be IEnumerable<T> (private accessibility) |
◽️ Notice | 1 |
Some values of the enum are not processed inside 'switch' statement |
◽️ Notice | 1 |
Use deconstruction |
◽️ Notice | 1 |
Convert 'as' expression type check and the following null check into negated pattern matching |
◽️ Notice | 1 |
Replace if statement with null-propagating code |
◽️ Notice | 1 |
Use object or collection initializer when possible |
◽️ Notice | 1 |
Use raw string |
◽️ Notice | 1 |
Literal length can be reduced by using verbatim string |
◽️ Notice | 1 |
Virtual (overridable) member is never overridden (non-private accessibility) |
◽️ Notice | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 71 in src/NexusMods.DataModel/Games/GamePath.cs
github-actions / Qodana for .NET
Use preferred style of 'new' expression when created type is evident
Redundant type specification
Check notice on line 74 in src/NexusMods.DataModel/Games/GamePath.cs
github-actions / Qodana for .NET
Use preferred style of 'new' expression when created type is evident
Redundant type specification
Check notice on line 216 in src/NexusMods.App.UI/Overlays/Updater/UpdaterViewModel.cs
github-actions / Qodana for .NET
Use preferred style of 'new' expression when created type is evident
Redundant type specification
Check notice on line 25 in src/NexusMods.CLI/Verbs/DownloadLinks.cs
github-actions / Qodana for .NET
Use preferred style of 'new' expression when created type is evident
Redundant type specification
Check notice on line 15 in src/NexusMods.App.UI/RightContent/Downloads/InProgressDesignViewModel.cs
github-actions / Qodana for .NET
Use preferred style of 'new' expression when created type is not evident
Missing type specification
Check notice on line 18 in src/Games/NexusMods.Games.Sifu/Sifu.cs
github-actions / Qodana for .NET
Use preferred style of 'new' expression when created type is not evident
Missing type specification
Check notice on line 19 in benchmarks/NexusMods.Benchmarks/Program.cs
github-actions / Qodana for .NET
Remove redundant parentheses
Redundant parentheses
Check notice on line 138 in src/NexusMods.DataModel/Games/AGame.cs
github-actions / Qodana for .NET
Remove redundant parentheses
Redundant parentheses
github-actions / Qodana for .NET
Remove redundant parentheses
Redundant parentheses
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check warning on line 61 in src/NexusMods.App.UI/Overlays/IOverlayController.cs
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check warning on line 66 in src/NexusMods.App.UI/Overlays/IOverlayController.cs
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check warning on line 67 in src/NexusMods.App.UI/Overlays/IOverlayController.cs
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check notice on line 193 in src/NexusMods.DataModel/ArchiveInstaller.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 20 in src/Networking/NexusMods.Networking.NexusWebApi.NMA/TypeFinder.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 35 in src/Networking/NexusMods.Networking.NexusWebApi/Verbs/NexusApiVerify.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 19 in src/NexusMods.App.UI/Controls/Spine/SpineDesignViewModel.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 66 in src/Games/NexusMods.Games.StardewValley/StardewValley.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 88 in src/NexusMods.StandardGameLocators/Services.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style
Check notice on line 14 in src/Games/NexusMods.Games.TestHarness/TypeFinder.cs
github-actions / Qodana for .NET
Use preferred style for trailing comma before new line in multiline lists
Remove trailing comma to conform to code style