Add entire column/row (#814) #653
693 new problems found by Qodana for .NET
Qodana for .NET
693 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Redundant using directive |
🔶 Warning | 212 |
Redundant type declaration body |
🔶 Warning | 58 |
Use of obsolete symbol |
🔶 Warning | 54 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 43 |
Unused parameter (private accessibility) |
🔶 Warning | 25 |
Unused local variable |
🔶 Warning | 23 |
Namespace does not correspond to file location |
🔶 Warning | 22 |
Invalid XML documentation comment |
🔶 Warning | 20 |
Missing XML comment for publicly visible type or member |
🔶 Warning | 19 |
Async function without await expression |
🔶 Warning | 17 |
Redundant nullable warning suppression expression |
🔶 Warning | 16 |
Non-accessed field (private accessibility) |
🔶 Warning | 14 |
Assignment is not used |
🔶 Warning | 12 |
Redundant namespace alias |
🔶 Warning | 12 |
Parameter has no matching param tag in the XML comment |
🔶 Warning | 11 |
Redundant explicit type in array creation |
🔶 Warning | 11 |
Redundant member initializer |
🔶 Warning | 10 |
XML comment has a 'param' tag for 'Parameter', but there is no parameter by that name |
🔶 Warning | 8 |
Resource is not overridden in specific culture |
🔶 Warning | 8 |
Variable in local function hides variable from outer scope |
🔶 Warning | 8 |
Static resource not resolved |
🔶 Warning | 8 |
Cannot resolve reference in XML comment |
🔶 Warning | 6 |
Non-accessed positional property (non-private accessibility) |
🔶 Warning | 6 |
Type member is never used (private accessibility) |
🔶 Warning | 6 |
Add/remove 'this.' qualifier |
🔶 Warning | 4 |
Private field can be converted into local variable |
🔶 Warning | 4 |
Return type of a function can be non-nullable |
🔶 Warning | 4 |
Dereference of a possibly null reference. |
🔶 Warning | 3 |
Collection content is never queried (private accessibility) |
🔶 Warning | 3 |
Use preferred 'var' style (for built-in types) |
🔶 Warning | 3 |
Access to modified captured variable |
🔶 Warning | 2 |
Keyword 'new' is required |
🔶 Warning | 2 |
Ambiguous reference in XML comment |
🔶 Warning | 2 |
Possible null reference argument for a parameter. |
🔶 Warning | 2 |
Non-nullable member is uninitialized. |
🔶 Warning | 2 |
Usage of <inheritdoc /> is invalid |
🔶 Warning | 2 |
Member initialized value ignored |
🔶 Warning | 2 |
Return value of [MustUseReturnValue] annotated method is not used |
🔶 Warning | 2 |
Redundant type arguments of method |
🔶 Warning | 2 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 2 |
RoslynAnalyzers Do not use blocking task operations in test method |
🔶 Warning | 2 |
Avoid using 'async' lambda when delegate type returns 'void' |
🔶 Warning | 1 |
Code is unreachable |
🔶 Warning | 1 |
XML comment has a 'typeparam' tag for 'TypeParameter', but there is no type parameter by that name |
🔶 Warning | 1 |
Collection content is never queried (non-private accessibility) |
🔶 Warning | 1 |
Collection is never updated (non-private accessibility) |
🔶 Warning | 1 |
Expression is always 'true' or 'false' according to nullable reference types' annotations |
🔶 Warning | 1 |
Empty constructor |
🔶 Warning | 1 |
Empty namespace declaration |
🔶 Warning | 1 |
Empty statement is redundant |
🔶 Warning | 1 |
Return value of a method annotated with [MustDisposeResource] is never disposed |
🔶 Warning | 1 |
Mismatch of optional parameter value in overridden method |
🔶 Warning | 1 |
Possibly impure struct method is called on readonly variable: struct value always copied before invocation |
🔶 Warning | 1 |
Redundant empty object or collection initializer |
🔶 Warning | 1 |
Redundant explicit tuple component name |
🔶 Warning | 1 |
Redundant class or interface specification in base types list |
🔶 Warning | 1 |
Redundant name qualifier |
🔶 Warning | 1 |
Redundant 'object.ToString()' call |
🔶 Warning | 1 |
Static member initializer refers to static member below or in other part |
🔶 Warning | 1 |
Field is never used |
🔶 Warning | 1 |
Local function is never used |
🔶 Warning | 1 |
Virtual member call in constructor |
🔶 Warning | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 78 in tests/NexusMods.DataModel.Tests/ALoadoutSynchronizerTests.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 430 in src/NexusMods.DataModel/Loadouts/LoadoutRegistry.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check warning on line 61 in src/NexusMods.App.UI/Overlays/IOverlayController.cs
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check warning on line 66 in src/NexusMods.App.UI/Overlays/IOverlayController.cs
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check warning on line 67 in src/NexusMods.App.UI/Overlays/IOverlayController.cs
github-actions / Qodana for .NET
Add/remove 'this.' qualifier
Qualifier 'this.' is redundant
Check warning on line 77 in src/NexusMods.DataModel/CommandLine/Verbs/LoadoutManagementVerbs.cs
github-actions / Qodana for .NET
Avoid using 'async' lambda when delegate type returns 'void'
Avoid using 'async' lambda when delegate type returns 'void'
Check warning on line 12 in src/NexusMods.DataModel/JsonConverters/AExpressionConverterGenerator.cs
github-actions / Qodana for .NET
Keyword 'new' is required
The keyword 'new' is required on 'Type' because it hides property 'Type System.Text.Json.Serialization.JsonConverter.Type'
Check warning on line 28 in tests/NexusMods.UI.Tests/AVmTest.cs
github-actions / Qodana for .NET
Keyword 'new' is required
The keyword 'new' is required on 'LoadoutRegistry' because it hides property 'LoadoutRegistry NexusMods.UI.Tests.AUiTest.LoadoutRegistry'
github-actions / Qodana for .NET
Code is unreachable
Code is unreachable
Check warning on line 34 in src/NexusMods.App.UI/RightContent/Downloads/InProgressView.axaml.cs
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
Check warning on line 18 in src/NexusMods.App.UI/Overlays/Updater/UpdaterView.axaml.cs
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
Check warning on line 26 in src/NexusMods.App.UI/RightContent/LoadoutGrid/LoadoutGridView.axaml.cs
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
Check warning on line 26 in src/NexusMods.App.UI/RightContent/Downloads/InProgressView.axaml.cs
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
Check warning on line 40 in src/NexusMods.App.UI/LeftMenu/Items/LaunchButtonView.axaml.cs
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
Check warning on line 22 in src/NexusMods.App.UI/RightContent/LoadoutGrid/LoadoutGridView.axaml.cs
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
Check warning on line 30 in src/NexusMods.App.UI/RightContent/Downloads/InProgressView.axaml.cs
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.
github-actions / Qodana for .NET
Use of obsolete symbol
CS0618: Method 'NexusMods.App.UI.ReactiveUiExtensions.BindToUi(this IObservable, TTarget?, Expression\>, object?, IBindingTypeConverter?)' is obsolete: This should not be used anymore. See UI Coding Conventions for more details.