fixed hanging renderer thread when executing inter-thread actions (#1…

…5185) * fixed hanging renderer thread when executing inter-thread actions * readded changelog dialog --------- Co-authored-by: insomnious <[email protected]>
Nexus-Mods · Jan 25, 2024 · f2408e2 · f2408e2
1 parent f0c5caa
commit f2408e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/actions/notifications.ts b/src/actions/notifications.ts
@@ -80,26 +80,26 @@ export function fireNotificationAction(notiId: string, notiProcess: string,
 
 if (ipcMain !== undefined) {
   ipcMain.on('fire-notification-action',
-             (event: Electron.Event, notiId: string, action: number) => {
+             (event: any, notiId: string, action: number) => {
     const func = notificationActions[notiId]?.[action];
-    //let res = false;
+    let res = false;
     if (func !== undefined) {
       func(() => {
-        //res = true;
+        res = true;
       });
     }
 
-    event.preventDefault();
+    event.returnValue = res;
   });
 
   ipcMain.on('fire-dialog-action',
-             (event: Electron.Event, dialogId: string, action: string, input: any) => {
+             (event: any, dialogId: string, action: string, input: any) => {
     const func = DialogCallbacks.instance()[dialogId];
     if (func !== undefined) {
       func(action, input);
       delete DialogCallbacks.instance()[dialogId];
     }
-    //event.returnValue = true;
+    event.returnValue = true;
   });
 }
 

diff --git a/src/extensions/updater/autoupdater.ts b/src/extensions/updater/autoupdater.ts
@@ -243,7 +243,7 @@ function setupAutoUpdate(api: IExtensionApi) {
         type: 'success',
         message: 'Update available',
         actions: [
-          /*{
+          {
             title: 'Changelog',
             action: () => {
               api.store.dispatch(showDialog('info', `Changelog ${info.version}`, {
@@ -252,7 +252,7 @@ function setupAutoUpdate(api: IExtensionApi) {
                   { label: 'Close' },
                 ]));
             },
-          },*/
+          },
           {
             title: 'Restart & Install',
             action: () => {