Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed crash when attempting to group a mod that no longer exists #16613

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fixed crash when attempting to group a mod that no longer exists #16613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extensions/mod_management/util/modGrouping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function newestFirst(lhs: IModWithState, rhs: IModWithState): number {
*/
function byEnabled(input: IModWithState[]): IModWithState[][] {
// put each enabled mod into its own group. Ideally there should only be one
const groups: IModWithState[][] = input.filter((mod => mod.enabled)).map(mod => [mod]);
const groups: IModWithState[][] = input.filter((mod => mod?.enabled === true)).map(mod => [mod]);
// it is of course possible that no mod in input is enabled.
if (groups.length === 0) {
return [ input ];
Expand Down