Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: PiHole Plugin #3876

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

luca910
Copy link

@luca910 luca910 commented Jul 15, 2024

That far on creation of a new Proxy host a new DNS record is created in PiHole.
TODO: Update Method
TODO: Delete Method

The plugin requires new env vars for the npm container:
PIHOLE_IP
PIHOLE_PASSWORD

@luca910 luca910 changed the title Development PiHole Plugin Feature: PiHole Plugin Jul 15, 2024
@luca910
Copy link
Author

luca910 commented Jul 16, 2024

Update method:

  • delete
  • create

PiHole has not implemented a method to update local dbs records

@luca910 luca910 marked this pull request as ready for review July 16, 2024 20:36
@luca910
Copy link
Author

luca910 commented Jul 16, 2024

bruh

@luca910
Copy link
Author

luca910 commented Jul 16, 2024

The plugin can be enabled and configured with docker compose env vars.

Help would be appreciated since this plugin is enabled globally and not per proxy host entry.
Maybe via an extra radio button.

On the other hand, this may not be required since, outside the network, another DNS takes over with the public IP entry, if the domain is already existing and configured.

@luca910 luca910 marked this pull request as draft July 17, 2024 22:06
@nginxproxymanagerci
Copy link

Docker Image for build 4 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3876

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@luca910 luca910 marked this pull request as ready for review July 18, 2024 11:05
@CrazyWolf13
Copy link

That actually sounds awesome!

Hoping for a merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants