Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/CosmWasm/wasmvm from 1.4.0 to 1.4.1 #1629

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 9, 2023

Bumps github.com/CosmWasm/wasmvm from 1.4.0 to 1.4.1.

Release notes

Sourced from github.com/CosmWasm/wasmvm's releases.

v1.4.1

Build artifacts generated at this tag.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/CosmWasm/wasmvm](https://github.com/CosmWasm/wasmvm) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/CosmWasm/wasmvm/releases)
- [Changelog](https://github.com/CosmWasm/wasmvm/blob/main/CHANGELOG.md)
- [Commits](CosmWasm/wasmvm@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/CosmWasm/wasmvm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 9, 2023 18:08
@dependabot dependabot bot added dependabot For triggering workflows after dependabot recommendations dependencies Pull requests that update a dependency file labels Oct 9, 2023
@Unique-Divine Unique-Divine added dependabot For triggering workflows after dependabot recommendations and removed dependabot For triggering workflows after dependabot recommendations labels Oct 9, 2023
@Unique-Divine Unique-Divine enabled auto-merge (squash) October 9, 2023 18:54
@Unique-Divine Unique-Divine merged commit 15a49d1 into master Oct 9, 2023
14 checks passed
@Unique-Divine Unique-Divine deleted the dependabot/go_modules/github.com/CosmWasm/wasmvm-1.4.1 branch October 9, 2023 19:05
@helder-moreira
Copy link
Contributor

goreleaser also must be updated to download the correct libs

@Unique-Divine
Copy link
Member

Unique-Divine commented Oct 9, 2023

@helder-moreira, which file needs to be updated? I see:

  • contrib/make/release.mk, which depends on the version nibiru
  • contrib/docker/goreleaser.Dockerfile, which just uses binaries in a container
  • contrib/make/build.mk, which refers to $WASMVM_VERSION
WASMVM_VERSION := $(shell go list -m github.com/CosmWasm/wasmvm | awk '{sub(/^v/, "", $$2); print $$2}')

Where do we make the external lib changes?

@helder-moreira
Copy link
Contributor

@helder-moreira, which file needs to be updated? I see:

  • contrib/make/release.mk, which depends on the version nibiru

  • contrib/docker/goreleaser.Dockerfile, which just uses binaries in a container

  • contrib/make/build.mk, which refers to $WASMVM_VERSION

WASMVM_VERSION := $(shell go list -m github.com/CosmWasm/wasmvm | awk '{sub(/^v/, "", $$2); print $$2}')

Where do we make the external lib changes?

Should be .goreleaser.yml on project root. Both on darwin and linux builds.

@Unique-Divine
Copy link
Member

Ah, I see. Do you think we could load that version number from the go.mod directly similar to our build script?

@helder-moreira
Copy link
Contributor

Ah, I see. Do you think we could load that version number from the go.mod directly similar to our build script?

No, not in an easy way. But I can try to have a better look when possible. The problem is that you can't use env vars in pre-hooks.

@Unique-Divine
Copy link
Member

Ah, I see. Do you think we could load that version number from the go.mod directly similar to our build script?

No, not in an easy way. But I can try to have a better look when possible. The problem is that you can't use env vars in pre-hooks.

This should work. If you load it in the pre block instead of env, I think you get the expected behavior:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependabot For triggering workflows after dependabot recommendations dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants