chore: add v1.4.0 upgrade handler #1910
Conversation
WalkthroughThe changes involve integrating a new upgrade version 1.4.0 into the application. This includes importing the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant App
participant UpgradeManager
participant v1_4_0
User->>App: Initiate Upgrade Check
App->>UpgradeManager: Request Available Upgrades
UpgradeManager->>v1_4_0: Include v1_4_0 Upgrade
v1_4_0->>UpgradeManager: Provide Upgrade Details
UpgradeManager->>App: List of Upgrades (including v1_4_0)
App->>User: Display Available Upgrades
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- app/upgrades.go (1 hunks)
- app/upgrades/v1_4_0/constants.go (1 hunks)
Additional context used
golangci-lint
app/upgrades.go
[error] 22-22: undefined: NibiruApp (typecheck)
[error] 27-27: undefined: NibiruApp (typecheck)
[error] 33-33: undefined: NibiruApp (typecheck)
Additional comments not posted (2)
app/upgrades/v1_4_0/constants.go (1)
12-24: The constants and upgrade handler are well-defined and align with the Cosmos SDK's upgrade pattern.app/upgrades.go (1)
12-12: The import and addition of the v1.4.0 upgrade are correctly implemented.Also applies to: 19-19
| ) | ||
|
|
||
| var Upgrades = []upgrades.Upgrade{ | ||
| v1_1_0.Upgrade, | ||
| v1_2_0.Upgrade, | ||
| v1_3_0.Upgrade, | ||
| v1_4_0.Upgrade, | ||
| } | ||
|
|
||
| func (app *NibiruApp) setupUpgrades() { |
There was a problem hiding this comment.
The type NibiruApp is undefined in this context, which could lead to runtime errors.
- func (app *NibiruApp) setupUpgrades() {
+ func (app *App) setupUpgrades() {
- func (app *NibiruApp) setUpgradeHandlers() {
+ func (app *App) setUpgradeHandlers() {
- func (app *NibiruApp) setUpgradeStoreLoaders() {
+ func (app *App) setUpgradeStoreLoaders() {Also applies to: 27-27, 33-33
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| func (app *NibiruApp) setupUpgrades() { | |
| func (app *App) setupUpgrades() { | |
| ``` | |
| Also applies to: | |
| ```suggestion | |
| func (app *App) setUpgradeHandlers() { | |
| ``` | |
| ```suggestion | |
| func (app *App) setUpgradeStoreLoaders() { |
Tools
golangci-lint
[error] 22-22: undefined: NibiruApp (typecheck)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1910 +/- ##
==========================================
- Coverage 62.34% 62.14% -0.21%
==========================================
Files 245 245
Lines 15949 16010 +61
==========================================
+ Hits 9944 9950 +6
- Misses 5269 5323 +54
- Partials 736 737 +1
|
Purpose / Abstract
Add
v1.4.0upgrade handlerSummary by CodeRabbit