fix(evm): query of NIBI should use bank state, not the StateDB

[Unique-Divine]

Purpose / Abstract

• Closes bug(evm): de-synchronization between wasm bank balance and EVM account state #2133

Summary by CodeRabbit

• Bug Fixes

  • Fixed an issue with NIBI query to use the correct bank state instead of StateDB
  • Improved balance retrieval for Ethereum accounts by fetching balance directly from the bank

• Documentation

  • Updated CHANGELOG.md with the latest changes and issue reference

[coderabbitai]

Walkthrough

The pull request addresses a discrepancy in the Nibiru EVM's balance retrieval mechanism. The changes focus on modifying the EthAccount method in the grpc_query.go file to use the bank state for retrieving account balances, ensuring consistency between the bank balance and EVM account state. A corresponding changelog entry is added to document this fix, specifically noting that the NIBI query should now use the bank state instead of the StateDB.

Changes

File	Change Summary
CHANGELOG.md	Added entry for fix in EVM NIBI query, referencing issue #2134
x/evm/keeper/grpc_query.go	Modified EthAccount method to retrieve balance using k.Bank.GetBalance() instead of directly accessing account balance

Assessment against linked issues

Objective	Addressed	Explanation
Synchronize bank balance with EVM account state [#2133]	✅
Ensure consistent balance retrieval	✅

Possibly related PRs

• fix(evm): non-deterministic gas usage #2110: Restoration of StateDB state before ApplyEvmMsg call
• fix(evm): make conditional balance check free in gas cost #2114: Conditional balance checks in gas cost
• fix(evm): Guarantee that gas consumed during any send operation of the "NibiruBankKeeper" depends only on the "bankkeeper.BaseKeeper"'s gas consumption. #2119: Consistent gas consumption in NibiruBankKeeper
• fix: Use canonical hexadecimal strings for Eip155 address encoding #2120: Ethereum address encoding improvements

Poem

🐰 In the realm of Nibiru's code so bright,
A balance fix brings balance just right!
From StateDB's maze to bank's clear view,
Our NIBI query finds its true breakthrough
With rabbit precision, we've set things straight! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 666a58d and 532973e.

📒 Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• x/evm/keeper/grpc_query.go (1 hunks)

🔇 Additional comments (3)

x/evm/keeper/grpc_query.go (2)

68-68: Confirm bank retrieval logic is accurate
Fetching the account balance directly from the bank ensures alignment between the EVM state and the bank's ledger. This approach avoids discrepancies that could arise from using the StateDB alone. No issues spotted, looks good.

---

73-74: Use caution with possible large balances
Converting the bank balance to a string is straightforward, but be mindful of potential overflow scenarios in the future if the type ever changes or if extremely large balances occur. Overall, the logic meets the requirement of returning a consistent bank-based balance.

CHANGELOG.md (1)

56-56: Verify references to bank state fix
The changelog entry effectively communicates the fix regarding the shift from StateDB to bank state for NIBI queries. Ensure all references in the code indeed align with bank-based querying, accurately reflecting this changelog note.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.