feat: add bybit data source

[k-yang]

Original: #30

All credit goes to @burningxxx

Summary by CodeRabbit

• New Features
  • Added support for the Bybit price provider, enabling price fetching for additional symbols.
• Refactor
  • Renamed a response struct in the price provider code to improve clarity and specificity.
• Tests
  • Implemented tests for Bybit price updates, ensuring accuracy and reliability of price data retrieval.

[coderabbitai]

Walkthrough

The recent updates introduce a new price provider from Bybit, enhancing the system's ability to fetch and process cryptocurrency prices. This involves adding symbol mappings, supporting the Bybit price provider in the core logic, and implementing the functionality to retrieve and parse price data from the Bybit API. Additionally, the update includes a refinement in the handling of JSON data from OKEx by renaming a response struct for clarity.

Changes

Files	Change Summary
config/config.go	Added mappings for symbols in defaultExchangeSymbolsMap for Bybit.
feeder/priceprovider/.../priceprovider.go	Added support for Bybit in NewPriceProvider.
feeder/priceprovider/sources/bybit.go, feeder/priceprovider/sources/bybit_test.go	Introduced Bybit price fetching and testing.
feeder/priceprovider/sources/okex.go	Renamed Response struct to OkexResponse for clearer JSON data handling.

Poem

🐰 In the land of code and bytes,
A rabbit hopped through days and nights.
"A new provider!" it exclaimed with glee,
Fetching prices from Bybit, as fast as can be.
🌟 With symbols mapped and data parsed,
Our crypto quest, further embarked.
In tests and logs, the truth we cite,
Onward we hop, in the blockchain's light.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 71003f1 and 1d352cd.

Files selected for processing (5)

• config/config.go (1 hunks)
• feeder/priceprovider/priceprovider.go (1 hunks)
• feeder/priceprovider/sources/bybit.go (1 hunks)
• feeder/priceprovider/sources/bybit_test.go (1 hunks)
• feeder/priceprovider/sources/okex.go (2 hunks)

Additional comments: 5

feeder/priceprovider/sources/bybit_test.go (1)

• 13-20: Consider adding more comprehensive tests for BybitPriceUpdate, including scenarios where the API returns errors, malformed data, or empty responses. Testing these edge cases will ensure robust error handling and resilience of the function.

feeder/priceprovider/sources/okex.go (1)

• 26-26: The renaming of Response to OkexResponse enhances clarity and avoids potential naming conflicts. Good improvement.

feeder/priceprovider/sources/bybit.go (1)

• 29-67: In the BybitPriceUpdate function, consider enhancing the error messages to include more context, such as the URL or parameters involved in the request. This can aid in debugging and provide clearer insights into the nature of the error.

config/config.go (1)

• 53-60: The addition of Bybit mappings in defaultExchangeSymbolsMap is necessary for supporting the new data source. This change is correctly implemented.

feeder/priceprovider/priceprovider.go (1)

• 53-54: The addition of Bybit as a new price provider in the NewPriceProvider function is correctly implemented and aligns with the objective of integrating Bybit as a new data source.