Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: migration for v0.21 with passing tests #wip #238

Merged
merged 25 commits into from
Jul 8, 2023
Merged

epic: migration for v0.21 with passing tests #wip #238

merged 25 commits into from
Jul 8, 2023

Conversation

AnishP15
Copy link
Contributor

@AnishP15 AnishP15 commented Jul 5, 2023 •
edited by Unique-Divine
Loading

Merging v0.21 (pre-release) here as the only issues are related to gRPC inactive errors.
The migration will be complete after the following ticket is closed:

Evidence: Workflow as of f0e0363

image

=========================== short test summary info ============================
FAILED tests/bank_test.py::test_send_multiple_msgs - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 70F416E36783D36910DD5EFF5F018D1B22FDFD2AC1A679F5597A51DD091AEC0C"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 70F416E36783D36910DD5EFF5F018D1B22FDFD2AC1A679F5597A51DD091AEC0C", grpc_status:5, created_time:"2023-07-08T20:30:27.10667432+00:00"}"
>
FAILED tests/bank_test.py::test_send_single_msg - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: AF7904A3B4E840804370DAA018F74C141591DFD751888A566F41379B03A9ECD3"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: AF7904A3B4E840804370DAA018F74C141591DFD751888A566F41379B03A9ECD3", grpc_status:5, created_time:"2023-07-08T20:30:27.286525778+00:00"}"
>
FAILED tests/perp_test.py::test_open_position - AssertionError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: E093768601866ABB81BFC331544115A67F0052450E7044110A5A5C5E575E2143"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:27.527093327+00:00", grpc_status:5, grpc_message:"tx not found: E093768601866ABB81BFC331544115A67F0052450E7044110A5A5C5E575E2143"}"
>
FAILED tests/spot_test.py::test_spot_create_pool - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 5B84A6E4F7266082D00D52B691CF816A057CF3D4594B2DB12B6B12FE199DDF6A"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:27.78039951+00:00", grpc_status:5, grpc_message:"tx not found: 5B84A6E4F7266082D00D52B691CF816A057CF3D4594B2DB12B6B12FE199DDF6A"}"
>
FAILED tests/staking_test.py::test_query_delegation - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 5EFEC39B3945E5B069E45CF85264432543F0DF4CF6943917AE22F89CFBF26C9E"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 5EFEC39B3945E5B069E45CF85264432543F0DF4CF6943917AE22F89CFBF26C9E", grpc_status:5, created_time:"2023-07-08T20:30:28.003500525+00:00"}"
>
FAILED tests/staking_test.py::test_query_delegations - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: B12CA70AE1FE69BCED531583E0EDE6888BFA47BAAE1AC533984774EF466243D4"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: B12CA70AE1FE69BCED531583E0EDE6888BFA47BAAE1AC533984774EF466243D4", grpc_status:5, created_time:"2023-07-08T20:30:28.153547795+00:00"}"
>
FAILED tests/staking_test.py::test_query_delegations_to - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 454461B9E684A5B9F6A3F07A00A66E6C8CD4695E3F36993ACB0924408FFAE9BF"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:28.303779249+00:00", grpc_status:5, grpc_message:"tx not found: 454461B9E684A5B9F6A3F07A00A66E6C8CD4695E3F36993ACB0924408FFAE9BF"}"
>
FAILED tests/staking_test.py::test_unbonding_delegation - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 0152217C0388E04E532B9AE3D583931CC875F558782A19CC33E1F9712F1368DA"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:28.487905128+00:00", grpc_status:5, grpc_message:"tx not found: 0152217C0388E04E532B9AE3D583931CC875F558782A19CC33E1F9712F1368DA"}"
>
FAILED tests/staking_test.py::test_unbonding_delegations - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 3A6E267186AE96DC527619E37306A44F96260C671C0939EAFB65AD1E823C533C"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 3A6E267186AE96DC527619E37306A44F96260C671C0939EAFB65AD1E823C533C", grpc_status:5, created_time:"2023-07-08T20:30:28.636702355+00:00"}"
>
FAILED tests/staking_test.py::test_unbonding_delegations_from - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 6EC444F18040D982B221A6CD47AE98FFD640DA7509C46C18662849CBDF9CB8FA"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"[2023](https://github.com/NibiruChain/py-sdk/actions/runs/5496271046/jobs/10016193477?pr=238#step:13:2024)-07-08T20:30:28.78554624+00:00", grpc_status:5, grpc_message:"tx not found: 6EC444F18040D982B221A6CD47AE98FFD640DA7509C46C18662849CBDF9CB8FA"}"
>
FAILED tests/staking_test.py::test_staking_events - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 07DC63107512D43F951EF62FF1DCC4D750C0E85DC2E2AC9B4273FF39561AA5BD"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 07DC63107512D43F951EF62FF1DCC4D750C0E85DC2E2AC9B4273FF39561AA5BD", grpc_status:5, created_time:"2023-07-08T20:30:29.974500973+00:00"}"
>
FAILED tests/utils_test.py::test_get_block_messages - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: E115BCD37B34975A9982AB434041E12ADC535A7283C0FEDB2E39727AC3CF73AD"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: E115BCD37B34975A9982AB434041E12ADC535A7283C0FEDB2E39727AC3CF73AD", grpc_status:5, created_time:"2023-07-08T20:30:30.168367952+00:00"}"
>
=================== 12 failed, 60 passed, 2 skipped in 3.67s ===================

AnishP15 and others added 25 commits June 30, 2023 17:12
@AnishP15
Fixing imports for v0.21, need gogoproto for release
f366162 
 Please enter the commit message for your changes. Lines starting
@AnishP15
Broken epochs from nibiru_proto
65a34c1
@Unique-Divine
#wip: no import errors on test runs
8cb03cc
@AnishP15
saved #wip
e8b4e46
@AnishP15
fixed tx service halts #wip
72b3b79
@AnishP15
Pass spot tests if pool dne
8ed9157
@AnishP15
Fix stablecoin test
248532c 
w with '#' will be ignored, and an empty message aborts the commit.
@AnishP15
all passing tests on v0.21
5e797bc
@AnishP15
Ran pre-commit auto update
339e00b
@AnishP15
Add tx query to include missing fields from grpc resp
1154b57
@Unique-Divine
save #wip: fixing InactiveRpcError
75b72a3
@Unique-Divine
fix!: improvements to broadcast fn
772b7b4
@Unique-Divine
fix,docs(tx.py)!:
1d73353 
1. Make sequence errors near-impossible.
2. Use more type hints.
3. Improve wallet.Address initialization robustness.
@Unique-Divine
fix,ci(scripts): (1) Add --no-build flag for localnet.sh,
c3ec279 
(2) CI test the script, and (3) fix version on e2e action
@Unique-Divine
ci(scripts.yml): trigger run
21b16bb
@Unique-Divine
ci: fix typo
8834d98
@Unique-Divine
ci: lower the sleep time since the network starts pretty quickly
8262abf
@Unique-Divine
ci(scripts.yml): run localnet.sh in the background
3166b06
@Unique-Divine
appease linter
39022c4
@Unique-Divine
ci(lint.yml): make linter more specific
af91a02
@Unique-Divine
run black and flake8
ce6149e
@Unique-Divine
fix: both isort and black should be poetry 'dev' dependencies
e15615a
@Unique-Divine
ci(lint.yml): wrong job name
0da4df8
@Unique-Divine
ci(lint.yml): clean up workflow even more + concurrency restart
d5296aa
@Unique-Divine
ci(lint.yml): invalid run/uses syntax for job:lint-py
f0e0363
@Unique-Divine Unique-Divine added type: enhancement New feature or request type: test Adding missing tests or improve existing tests epic Large task that is a parent to several issues/tasks dependencies Pull requests that update a dependency file labels Jul 8, 2023
@Unique-Divine
Copy link
Member

Unique-Divine commented Jul 8, 2023 •
edited
Loading

Merging v0.21 (pre-release) here as the only issues are related to gRPC inactive errors.
The migration will be complete after the following ticket is closed:

Evidence: Workflow as of f0e0363

image

=========================== short test summary info ============================
FAILED tests/bank_test.py::test_send_multiple_msgs - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 70F416E36783D36910DD5EFF5F018D1B22FDFD2AC1A679F5597A51DD091AEC0C"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 70F416E36783D36910DD5EFF5F018D1B22FDFD2AC1A679F5597A51DD091AEC0C", grpc_status:5, created_time:"2023-07-08T20:30:27.10667432+00:00"}"
>
FAILED tests/bank_test.py::test_send_single_msg - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: AF7904A3B4E840804370DAA018F74C141591DFD751888A566F41379B03A9ECD3"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: AF7904A3B4E840804370DAA018F74C141591DFD751888A566F41379B03A9ECD3", grpc_status:5, created_time:"2023-07-08T20:30:27.286525778+00:00"}"
>
FAILED tests/perp_test.py::test_open_position - AssertionError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: E093768601866ABB81BFC331544115A67F0052450E7044110A5A5C5E575E2143"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:27.527093327+00:00", grpc_status:5, grpc_message:"tx not found: E093768601866ABB81BFC331544115A67F0052450E7044110A5A5C5E575E2143"}"
>
FAILED tests/spot_test.py::test_spot_create_pool - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 5B84A6E4F7266082D00D52B691CF816A057CF3D4594B2DB12B6B12FE199DDF6A"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:27.78039951+00:00", grpc_status:5, grpc_message:"tx not found: 5B84A6E4F7266082D00D52B691CF816A057CF3D4594B2DB12B6B12FE199DDF6A"}"
>
FAILED tests/staking_test.py::test_query_delegation - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 5EFEC39B3945E5B069E45CF85264432543F0DF4CF6943917AE22F89CFBF26C9E"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 5EFEC39B3945E5B069E45CF85264432543F0DF4CF6943917AE22F89CFBF26C9E", grpc_status:5, created_time:"2023-07-08T20:30:28.003500525+00:00"}"
>
FAILED tests/staking_test.py::test_query_delegations - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: B12CA70AE1FE69BCED531583E0EDE6888BFA47BAAE1AC533984774EF466243D4"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: B12CA70AE1FE69BCED531583E0EDE6888BFA47BAAE1AC533984774EF466243D4", grpc_status:5, created_time:"2023-07-08T20:30:28.153547795+00:00"}"
>
FAILED tests/staking_test.py::test_query_delegations_to - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 454461B9E684A5B9F6A3F07A00A66E6C8CD4695E3F36993ACB0924408FFAE9BF"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:28.303779249+00:00", grpc_status:5, grpc_message:"tx not found: 454461B9E684A5B9F6A3F07A00A66E6C8CD4695E3F36993ACB0924408FFAE9BF"}"
>
FAILED tests/staking_test.py::test_unbonding_delegation - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 0152217C0388E04E532B9AE3D583931CC875F558782A19CC33E1F9712F1368DA"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"2023-07-08T20:30:28.487905128+00:00", grpc_status:5, grpc_message:"tx not found: 0152217C0388E04E532B9AE3D583931CC875F558782A19CC33E1F9712F1368DA"}"
>
FAILED tests/staking_test.py::test_unbonding_delegations - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 3A6E267186AE96DC527619E37306A44F96260C671C0939EAFB65AD1E823C533C"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 3A6E267186AE96DC527619E37306A44F96260C671C0939EAFB65AD1E823C533C", grpc_status:5, created_time:"2023-07-08T20:30:28.636702355+00:00"}"
>
FAILED tests/staking_test.py::test_unbonding_delegations_from - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 6EC444F18040D982B221A6CD47AE98FFD640DA7509C46C18662849CBDF9CB8FA"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {created_time:"[2023](https://github.com/NibiruChain/py-sdk/actions/runs/5496271046/jobs/10016193477?pr=238#step:13:2024)-07-08T20:30:28.78554624+00:00", grpc_status:5, grpc_message:"tx not found: 6EC444F18040D982B221A6CD47AE98FFD640DA7509C46C18662849CBDF9CB8FA"}"
>
FAILED tests/staking_test.py::test_staking_events - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: 07DC63107512D43F951EF62FF1DCC4D750C0E85DC2E2AC9B4273FF39561AA5BD"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: 07DC63107512D43F951EF62FF1DCC4D750C0E85DC2E2AC9B4273FF39561AA5BD", grpc_status:5, created_time:"2023-07-08T20:30:29.974500973+00:00"}"
>
FAILED tests/utils_test.py::test_get_block_messages - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "tx not found: E115BCD37B34975A9982AB434041E12ADC535A7283C0FEDB2E39727AC3CF73AD"
	debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:9090 {grpc_message:"tx not found: E115BCD37B34975A9982AB434041E12ADC535A7283C0FEDB2E39727AC3CF73AD", grpc_status:5, created_time:"2023-07-08T20:30:30.168367952+00:00"}"
>
=================== 12 failed, 60 passed, 2 skipped in 3.67s ===================

@Unique-Divine Unique-Divine changed the title feat: migration for v0.21 with passing tests epic: migration for v0.21 with passing tests #wip Jul 8, 2023
@Unique-Divine Unique-Divine marked this pull request as ready for review July 8, 2023 20:35
@Unique-Divine Unique-Divine merged commit 498263e into master Jul 8, 2023
@Unique-Divine Unique-Divine deleted the ap/v0.21 branch July 8, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasmatt matthiasmatt Awaiting requested review from matthiasmatt

@k-yang k-yang Awaiting requested review from k-yang

@Unique-Divine Unique-Divine Awaiting requested review from Unique-Divine

@onikonychev onikonychev Awaiting requested review from onikonychev

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file epic Large task that is a parent to several issues/tasks type: enhancement New feature or request type: test Adding missing tests or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnishP15 @Unique-Divine