Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate pop-ups for accepting or rejecting updates and selecting folders #414

Conversation

Gathin23
Copy link
Collaborator

@Gathin23 Gathin23 commented Nov 6, 2023

Solves

#384

Copy link
Member

@jgresham jgresham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log statements should not be translated!

@jgresham
Copy link
Member

jgresham commented Nov 7, 2023

Otherwise looking good! (ignore icon)

Captura de pantalla 2023-11-06 a la(s) 5 29 40 p m

@Gathin23 Gathin23 changed the title WIP: Translate pop-ups for accepting or rejecting updates and selecting folders Translate pop-ups for accepting or rejecting updates and selecting folders Nov 7, 2023
@Gathin23 Gathin23 requested a review from jgresham November 7, 2023 11:00
src/main/updater.ts Outdated Show resolved Hide resolved
@Gathin23
Copy link
Collaborator Author

@jgresham Made the necessary changes to the fomat

@jgresham jgresham merged commit 823877c into NiceNode:fix/translation-update-modals Nov 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants