fix: conditional advanced/required options, require input on required fields in Add Node modal #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
corn-potage
commented
Nov 15, 2023
•
corn-potage
commented
- conditional render of advanced and required options
- require input on all required input fields before moving onto next screen (solves Block the users from moving forward in Add Node flow until required input is made #407 )
- moved advanced options right under required options like spec
✅ Deploy Preview for nndesign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
corn-potage
changed the title
|
Again, great work!! |
* preparing all sync modes for EL * moved advanced options above like spec * conditional styling to not display syncMode in nodeSettings * added syncModes components * added additional info to sync modes * added disabled mode for nodeSettings * fixed remove node title * permanently disable syncMode change in nodeSettings unless removed * added besu config key to disable in node settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.