Skip to content

Commit

Permalink
Make sure we actually skip emissives in Bbmodel generation
Browse files Browse the repository at this point in the history
Turns out that EarsFeatures is Copy and I was editing a copy of it instead of the original, whoops!
  • Loading branch information
NickAcPT committed Aug 27, 2024
1 parent e621000 commit e621000
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ impl<M: ArmorMaterial, I: ModelProjectImageIO> ModelGenerationProject<M, I> {
}
}

let features = EarsParser::parse(&texture)?;
let mut features = EarsParser::parse(&texture)?;

if let (Some(features), Ok(None)) = (features, alfalfa) {
let wings_enabled = features.wing.is_some();
Expand All @@ -164,7 +164,7 @@ impl<M: ArmorMaterial, I: ModelProjectImageIO> ModelGenerationProject<M, I> {
}
}

if let Some(mut features) = features {
if let Some(ref mut features) = features {
// Harcode emissives to false - I believe blockbench supports emissive textures,
// but Ears skins' emissives aren't separate textures, and instead are based off of specific colors.
features.emissive = false;
Expand Down

0 comments on commit e621000

Please sign in to comment.