Fix file searcher no installation (#85)

* add asserts to narrow down the issue * Add test results * Update README.md status badges. * fix installation not being set after load. --------- Co-authored-by: GitHub Action <[email protected]>
NickHugi · Mar 14, 2024 · db5e1a9 · db5e1a9
1 parent d2c2895
commit db5e1a9
Show file tree

Hide file tree

Showing 50 changed files with 4,419 additions and 4,417 deletions.
diff --git a/README.md b/README.md
diff --git a/Tools/HolocronToolset/src/toolset/gui/dialogs/search.py b/Tools/HolocronToolset/src/toolset/gui/dialogs/search.py
@@ -38,6 +38,7 @@ def __init__(self, parent: QWidget | None, installations: dict[str, HTInstallati
         from toolset.uic.dialogs import search  # pylint: disable=C0415  # noqa: PLC0415
         self.ui = search.Ui_Dialog()
         self.ui.setupUi(self)
+        assert len(installations) > 0, "No installations passed to FileSearcher"
 
         self._installations: dict[str, HTInstallation] = installations
         for name, installation in installations.items():
@@ -62,6 +63,7 @@ def accept(self):
             None
         """
         installation: HTInstallation = self.ui.installationSelect.currentData()
+        assert bool(installation), "No installation chosen in FileSearcher"
         caseSensitive = self.ui.caseSensitiveRadio.isChecked()
         filenamesOnly = self.ui.filenamesOnlyCheck.isChecked()
         text = self.ui.searchTextEdit.text()

diff --git a/Tools/HolocronToolset/src/toolset/gui/windows/main.py b/Tools/HolocronToolset/src/toolset/gui/windows/main.py
@@ -917,6 +917,7 @@ def task(active: HTInstallation | None = None):
             self.dogObserver = Observer()
             self.dogObserver.schedule(self.dogHandler, self.active.path(), recursive=True)
             self.dogObserver.start()
+            self.installations[name] = self.active
 
         self.settings.installations()[name].path = path
 

diff --git a/...0cd0bcd49edb0f06227c3d76c2465d8bcfb4453/pytest_report_macos-12_3.10_x64/pytest_report.xml b/...0cd0bcd49edb0f06227c3d76c2465d8bcfb4453/pytest_report_macos-12_3.10_x64/pytest_report.xml