-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DLG camera angle selection #97
Merged
th3w1zard1
merged 1 commit into
NickHugi:master
from
th3w1zard1:fix-dlg-camera-angle-selector
Mar 29, 2024
Merged
Fix DLG camera angle selection #97
th3w1zard1
merged 1 commit into
NickHugi:master
from
th3w1zard1:fix-dlg-camera-angle-selector
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th3w1zard1
added a commit
that referenced
this pull request
Mar 30, 2024
commit d9e06e9 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:30:45 2024 -0500 Update dlg.py commit b1c3243 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:29:21 2024 -0500 Update dlg.py commit bb028ed Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:29:04 2024 -0500 properly use the new spinbox commit 3f6cc05 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:13:26 2024 -0500 toolset dlg: use proper range for camera animation commit 235d558 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:12:49 2024 -0500 Fix critical bug when extracting resources commit e341d0e Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 10:40:49 2024 -0500 improve gff.compare diff output commit 9f50e04 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 11:02:44 2024 -0500 Fix DLG camera angle selection (#97) commit 495a766 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:51:26 2024 -0500 fix incorrect check commit 2c83e58 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:30:19 2024 -0500 disable debug mode commit 3f0c3b5 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:26:33 2024 -0500 remove the test environment commit 8590dac Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:32:55 2024 -0500 update the legacy json file commit 9c5ec11 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:26:29 2024 -0500 Update config.py commit b6057b3 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:25:21 2024 -0500 Update config.py commit e55cea2 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:18:37 2024 -0500 Update config.py commit e7157ff Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:01:06 2024 -0500 fix main repo clearing the cache after fork sload commit b1c6725 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:37:32 2024 -0500 Move a few bleeding-edge fixes before i forget commit 3aa8a56 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:23:53 2024 -0500 Update config.py commit a334524 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:22:08 2024 -0500 Fully open source the compile process (#96) * Create select_update.py * get it runnable for testing * Update select_update.py * Add test results, prepare README * Update README.md status badges. * Add test results, prepare README * Update README.md status badges. * save changes for later * Add test results, prepare README * Update README.md status badges. * add more options * Add test results, prepare README * Update README.md status badges. * Update select_update.py * Add test results, prepare README * Update README.md status badges. * Update select_update.py * Update release_toolset.yml * get an implementation working * Update requirements.txt * fix a few things * Update publish_pykotor.yml * Update release_toolset.yml * Update compile_toolset.ps1 * Update release_toolset.yml * improve `def is_frozen` * change when workflows run. * Update run_and_report_pytests.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * test brew `--no-binaries` * Update release_toolset.yml * fix tag regex in toolset release workflow * Update install_python_venv.ps1 * possibly fix brew's link problem * fix progress hooks & cleanup * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update release_toolset.yml * Update release_toolset.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update publish_pykotor.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * add retry logic. * Update tkinter-like dependency scripts * Update publish_pykotor.yml * don't use brew in tkinter-like dep scripts * potentially fix 3.12 win runner * pwsh: fix infinite loop on ubuntu/debian * Update release_toolset.yml * don't upx compress the ucrt runtime dll's * Update install_python_venv.ps1 * Update release_toolset.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * fix infinite loop on ubuntu * Update release_toolset.yml * fix * Update release_toolset.yml * fix, also implement UpdateDialog * fix set-location not changing back to originalDir * add another upx exclude * Update install_python_venv.ps1 * Update release_toolset.yml * Update release_toolset.yml * Update select_update.py * Update select_update.py --------- Co-authored-by: GitHub Action <[email protected]> commit c9507fc Author: GitHub Action <[email protected]> Date: Thu Mar 28 06:55:29 2024 +0000 Update README.md status badges. commit 01ee6ec Author: GitHub Action <[email protected]> Date: Thu Mar 28 06:55:27 2024 +0000 Add test results, prepare README commit 11fa57b Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 01:28:33 2024 -0500 Refactor workflows (#92) * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * cleanup requirements * Add test results, prepare README * Update README.md status badges. * test release workflows. * Add test results, prepare README * Update README.md status badges. * fix * Update release_holopatcher.yml * Add test results, prepare README * Update README.md status badges. * ensure archived before release step. * Add test results, prepare README * Update README.md status badges. * Fix `install_powershell.sh` on Arch linux. * Add test results, prepare README * Update README.md status badges. * massively refactor scripts, improve stability&test * Fix debian/ubuntu installs * fix infinite loop due to incorrect arg type * Update install_python_venv.ps1 * Update run_and_report_pytests.yml * Update run_and_report_pytests.yml * handle the curl redirects correctly * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * add a log to see what the heck is breaking. * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * fix * Update run_and_report_pytests.yml * potentially fix mismatched x86/x64 * github runners x86 apparently are still 64-bit * fix the env * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update publish_pykotor.yml * Add test results, prepare README * Update README.md status badges. --------- Co-authored-by: GitHub Action <[email protected]> commit 06247a8 Author: GitHub Action <[email protected]> Date: Thu Mar 28 00:34:09 2024 +0000 Update README.md status badges. commit 3ca2d7a Author: GitHub Action <[email protected]> Date: Thu Mar 28 00:34:06 2024 +0000 Add test results, prepare README commit 105d237 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 19:19:59 2024 -0500 cleanup. for the billionth time. Repo is enormous. commit c24aa2c Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:44:13 2024 +0000 Update README.md status badges. commit 3f22707 Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:44:11 2024 +0000 Add test results, prepare README commit 8520aa6 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:24:45 2024 -0500 cleanup commit ea772a0 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:21:07 2024 -0500 Properly cleanup the toolset on exit. commit 5d247b8 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:20:18 2024 -0500 #95 (continuation of #94) commit a3efdad Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:16:43 2024 -0500 Update path.py (#94) commit 16e252d Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:10:03 2024 +0000 Update README.md status badges. commit fc1cc87 Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:10:01 2024 +0000 Add test results, prepare README commit 8c10be7 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 16:58:29 2024 -0500 Conditional concurrent resource loading of installation (#93) as reported in #bugs, the multithreaded installation can be dramatically slower on some systems. Disable by default. commit d257bc3 Author: GitHub Action <[email protected]> Date: Wed Mar 27 10:53:15 2024 +0000 Update README.md status badges. commit b74cdb2 Author: GitHub Action <[email protected]> Date: Wed Mar 27 10:53:13 2024 +0000 Add test results, prepare README commit 89cb080 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 05:22:15 2024 -0500 fix incorrect restype using of TPCEditor commit ad1a8b6 Author: GitHub Action <[email protected]> Date: Tue Mar 26 14:11:04 2024 +0000 Update README.md status badges. commit 3a171ac Author: GitHub Action <[email protected]> Date: Tue Mar 26 14:11:02 2024 +0000 Add test results, prepare README commit 79407c8 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:42:58 2024 -0500 logging commit 0926953 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:27:41 2024 -0500 Update requirements-dev.txt commit b5f3747 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:25:58 2024 -0500 more logging commit 6551a05 Author: GitHub Action <[email protected]> Date: Tue Mar 26 13:22:08 2024 +0000 Update README.md status badges. commit fbbd148 Author: GitHub Action <[email protected]> Date: Tue Mar 26 13:22:06 2024 +0000 Add test results, prepare README commit f3ccc42 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:07:07 2024 -0500 Update registry.py commit e5ecc9f Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:06:32 2024 -0500 fix critical bug with find_software_key commit 98361b7 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:04:48 2024 -0500 cleanup commit fce2790 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:49:55 2024 -0500 cleanup some things, implement the logger more commit f2db1f2 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:32:11 2024 -0500 Update registry.py commit 81e0736 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:29:36 2024 -0500 Update registry.py commit ebbae0d Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:24:08 2024 -0500 Fix missing exception object in catch statement commit 172c547 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:23:55 2024 -0500 cleanup some logging commit 7717a2c Author: GitHub Action <[email protected]> Date: Tue Mar 26 02:21:08 2024 +0000 Update README.md status badges. commit cb6cfef Author: GitHub Action <[email protected]> Date: Tue Mar 26 02:21:06 2024 +0000 Add test results, prepare README commit 4c6c214 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 21:08:50 2024 -0500 fix some typing commit 974c9ca Author: GitHub Action <[email protected]> Date: Mon Mar 25 18:59:48 2024 +0000 Update README.md status badges. commit 06c7d8e Author: GitHub Action <[email protected]> Date: Mon Mar 25 18:59:46 2024 +0000 Add test results, prepare README commit 9bc9a28 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 13:28:39 2024 -0500 cleanup module designer commit eda77db Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 13:02:39 2024 -0500 `ruff check .` commit 7f298a0 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 12:59:03 2024 -0500 implement partials for the logger commit ef393d1 Author: GitHub Action <[email protected]> Date: Mon Mar 25 00:43:14 2024 +0000 Update README.md status badges. commit 7290bec Author: GitHub Action <[email protected]> Date: Mon Mar 25 00:43:11 2024 +0000 Add test results, prepare README commit bf4c399 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 24 19:06:02 2024 -0500 cleanup nwnnsscomp abstraction commit 9a5fb1f Author: GitHub Action <[email protected]> Date: Sun Mar 24 17:25:22 2024 +0000 Update README.md status badges. commit e579da2 Author: GitHub Action <[email protected]> Date: Sun Mar 24 17:25:20 2024 +0000 Add test results, prepare README
th3w1zard1
added a commit
that referenced
this pull request
Mar 31, 2024
commit 510cc07 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 01:47:05 2024 -0500 add some guard clauses and cleanup UTIEditor commit ed0af80 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 01:45:52 2024 -0500 cleanup InventoryEditor commit 9b361e5 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 01:45:24 2024 -0500 cleanup section of UTCEditor commit df27066 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 00:18:47 2024 -0500 fix incorrect None returns in UTCEditor also fix the unused batchCacheTPC func commit eaa94fa Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 00:01:48 2024 -0500 cleanup pathlib overrides commit 211baa6 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 20:37:22 2024 -0500 fix some workflow scripts (sorry for the force push, there's 19 messy commits this'll squash) commit 33d0ee3 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:47:23 2024 -0500 Update tasks.json commit a3328f8 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:41:20 2024 -0500 don't call `_join` on windows. commit bdfeffc Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:34:24 2024 -0500 Update config.py commit 2961f22 Merge: fb3b0a0 57f466d Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:27:21 2024 -0500 Merge branch 'master' of https://github.com/NickHugi/PyKotor into NickHugi/master commit fb3b0a0 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:27:19 2024 -0500 Update README.md commit 57f466d Author: GitHub Action <[email protected]> Date: Sat Mar 30 05:31:18 2024 +0000 Update README.md status badges. commit a07a43f Author: GitHub Action <[email protected]> Date: Sat Mar 30 05:31:16 2024 +0000 Add test results, prepare README commit 5fcb708 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:49:39 2024 -0500 Update README.md commit 54abae5 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:36:32 2024 -0500 Update release_toolset.yml commit 3c69403 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:13:02 2024 -0500 Update release_toolset.yml commit c7d727c Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:12:21 2024 -0500 Update release_toolset.yml commit 9afb1c2 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:10:55 2024 -0500 Update release_toolset.yml commit f4e76db Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:10:10 2024 -0500 Update config.py commit d9e06e9 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:30:45 2024 -0500 Update dlg.py commit b1c3243 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:29:21 2024 -0500 Update dlg.py commit bb028ed Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:29:04 2024 -0500 properly use the new spinbox commit 3f6cc05 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:13:26 2024 -0500 toolset dlg: use proper range for camera animation commit 235d558 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:12:49 2024 -0500 Fix critical bug when extracting resources commit e341d0e Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 10:40:49 2024 -0500 improve gff.compare diff output commit 9f50e04 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 11:02:44 2024 -0500 Fix DLG camera angle selection (#97) commit 495a766 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:51:26 2024 -0500 fix incorrect check commit 2c83e58 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:30:19 2024 -0500 disable debug mode commit 3f0c3b5 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:26:33 2024 -0500 remove the test environment commit 8590dac Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:32:55 2024 -0500 update the legacy json file commit 9c5ec11 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:26:29 2024 -0500 Update config.py commit b6057b3 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:25:21 2024 -0500 Update config.py commit e55cea2 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:18:37 2024 -0500 Update config.py commit e7157ff Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:01:06 2024 -0500 fix main repo clearing the cache after fork sload commit b1c6725 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:37:32 2024 -0500 Move a few bleeding-edge fixes before i forget commit 3aa8a56 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:23:53 2024 -0500 Update config.py commit a334524 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:22:08 2024 -0500 Fully open source the compile process (#96) * Create select_update.py * get it runnable for testing * Update select_update.py * Add test results, prepare README * Update README.md status badges. * Add test results, prepare README * Update README.md status badges. * save changes for later * Add test results, prepare README * Update README.md status badges. * add more options * Add test results, prepare README * Update README.md status badges. * Update select_update.py * Add test results, prepare README * Update README.md status badges. * Update select_update.py * Update release_toolset.yml * get an implementation working * Update requirements.txt * fix a few things * Update publish_pykotor.yml * Update release_toolset.yml * Update compile_toolset.ps1 * Update release_toolset.yml * improve `def is_frozen` * change when workflows run. * Update run_and_report_pytests.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * test brew `--no-binaries` * Update release_toolset.yml * fix tag regex in toolset release workflow * Update install_python_venv.ps1 * possibly fix brew's link problem * fix progress hooks & cleanup * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update release_toolset.yml * Update release_toolset.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update publish_pykotor.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * add retry logic. * Update tkinter-like dependency scripts * Update publish_pykotor.yml * don't use brew in tkinter-like dep scripts * potentially fix 3.12 win runner * pwsh: fix infinite loop on ubuntu/debian * Update release_toolset.yml * don't upx compress the ucrt runtime dll's * Update install_python_venv.ps1 * Update release_toolset.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * fix infinite loop on ubuntu * Update release_toolset.yml * fix * Update release_toolset.yml * fix, also implement UpdateDialog * fix set-location not changing back to originalDir * add another upx exclude * Update install_python_venv.ps1 * Update release_toolset.yml * Update release_toolset.yml * Update select_update.py * Update select_update.py --------- Co-authored-by: GitHub Action <[email protected]> commit c9507fc Author: GitHub Action <[email protected]> Date: Thu Mar 28 06:55:29 2024 +0000 Update README.md status badges. commit 01ee6ec Author: GitHub Action <[email protected]> Date: Thu Mar 28 06:55:27 2024 +0000 Add test results, prepare README commit 11fa57b Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 01:28:33 2024 -0500 Refactor workflows (#92) * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * cleanup requirements * Add test results, prepare README * Update README.md status badges. * test release workflows. * Add test results, prepare README * Update README.md status badges. * fix * Update release_holopatcher.yml * Add test results, prepare README * Update README.md status badges. * ensure archived before release step. * Add test results, prepare README * Update README.md status badges. * Fix `install_powershell.sh` on Arch linux. * Add test results, prepare README * Update README.md status badges. * massively refactor scripts, improve stability&test * Fix debian/ubuntu installs * fix infinite loop due to incorrect arg type * Update install_python_venv.ps1 * Update run_and_report_pytests.yml * Update run_and_report_pytests.yml * handle the curl redirects correctly * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * add a log to see what the heck is breaking. * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * fix * Update run_and_report_pytests.yml * potentially fix mismatched x86/x64 * github runners x86 apparently are still 64-bit * fix the env * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update publish_pykotor.yml * Add test results, prepare README * Update README.md status badges. --------- Co-authored-by: GitHub Action <[email protected]> commit 06247a8 Author: GitHub Action <[email protected]> Date: Thu Mar 28 00:34:09 2024 +0000 Update README.md status badges. commit 3ca2d7a Author: GitHub Action <[email protected]> Date: Thu Mar 28 00:34:06 2024 +0000 Add test results, prepare README commit 105d237 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 19:19:59 2024 -0500 cleanup. for the billionth time. Repo is enormous. commit c24aa2c Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:44:13 2024 +0000 Update README.md status badges. commit 3f22707 Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:44:11 2024 +0000 Add test results, prepare README commit 8520aa6 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:24:45 2024 -0500 cleanup commit ea772a0 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:21:07 2024 -0500 Properly cleanup the toolset on exit. commit 5d247b8 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:20:18 2024 -0500 #95 (continuation of #94) commit a3efdad Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:16:43 2024 -0500 Update path.py (#94) commit 16e252d Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:10:03 2024 +0000 Update README.md status badges. commit fc1cc87 Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:10:01 2024 +0000 Add test results, prepare README commit 8c10be7 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 16:58:29 2024 -0500 Conditional concurrent resource loading of installation (#93) as reported in #bugs, the multithreaded installation can be dramatically slower on some systems. Disable by default. commit d257bc3 Author: GitHub Action <[email protected]> Date: Wed Mar 27 10:53:15 2024 +0000 Update README.md status badges. commit b74cdb2 Author: GitHub Action <[email protected]> Date: Wed Mar 27 10:53:13 2024 +0000 Add test results, prepare README commit 89cb080 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 05:22:15 2024 -0500 fix incorrect restype using of TPCEditor commit ad1a8b6 Author: GitHub Action <[email protected]> Date: Tue Mar 26 14:11:04 2024 +0000 Update README.md status badges. commit 3a171ac Author: GitHub Action <[email protected]> Date: Tue Mar 26 14:11:02 2024 +0000 Add test results, prepare README commit 79407c8 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:42:58 2024 -0500 logging commit 0926953 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:27:41 2024 -0500 Update requirements-dev.txt commit b5f3747 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:25:58 2024 -0500 more logging commit 6551a05 Author: GitHub Action <[email protected]> Date: Tue Mar 26 13:22:08 2024 +0000 Update README.md status badges. commit fbbd148 Author: GitHub Action <[email protected]> Date: Tue Mar 26 13:22:06 2024 +0000 Add test results, prepare README commit f3ccc42 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:07:07 2024 -0500 Update registry.py commit e5ecc9f Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:06:32 2024 -0500 fix critical bug with find_software_key commit 98361b7 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:04:48 2024 -0500 cleanup commit fce2790 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:49:55 2024 -0500 cleanup some things, implement the logger more commit f2db1f2 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:32:11 2024 -0500 Update registry.py commit 81e0736 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:29:36 2024 -0500 Update registry.py commit ebbae0d Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:24:08 2024 -0500 Fix missing exception object in catch statement commit 172c547 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:23:55 2024 -0500 cleanup some logging commit 7717a2c Author: GitHub Action <[email protected]> Date: Tue Mar 26 02:21:08 2024 +0000 Update README.md status badges. commit cb6cfef Author: GitHub Action <[email protected]> Date: Tue Mar 26 02:21:06 2024 +0000 Add test results, prepare README commit 4c6c214 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 21:08:50 2024 -0500 fix some typing commit 974c9ca Author: GitHub Action <[email protected]> Date: Mon Mar 25 18:59:48 2024 +0000 Update README.md status badges. commit 06c7d8e Author: GitHub Action <[email protected]> Date: Mon Mar 25 18:59:46 2024 +0000 Add test results, prepare README commit 9bc9a28 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 13:28:39 2024 -0500 cleanup module designer commit eda77db Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 13:02:39 2024 -0500 `ruff check .` commit 7f298a0 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 12:59:03 2024 -0500 implement partials for the logger commit ef393d1 Author: GitHub Action <[email protected]> Date: Mon Mar 25 00:43:14 2024 +0000 Update README.md status badges. commit 7290bec Author: GitHub Action <[email protected]> Date: Mon Mar 25 00:43:11 2024 +0000 Add test results, prepare README commit bf4c399 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 24 19:06:02 2024 -0500 cleanup nwnnsscomp abstraction commit 9a5fb1f Author: GitHub Action <[email protected]> Date: Sun Mar 24 17:25:22 2024 +0000 Update README.md status badges. commit e579da2 Author: GitHub Action <[email protected]> Date: Sun Mar 24 17:25:20 2024 +0000 Add test results, prepare README
th3w1zard1
added a commit
that referenced
this pull request
Apr 5, 2024
commit 4fdf579 Author: Benjamin Auquite <[email protected]> Date: Fri Apr 5 04:15:27 2024 -0500 cleanup unused imports commit b5f8551 Author: GitHub Action <[email protected]> Date: Fri Apr 5 05:32:54 2024 +0000 Update README.md status badges. commit a30deb2 Author: GitHub Action <[email protected]> Date: Fri Apr 5 05:32:52 2024 +0000 Add test results, prepare README commit 6d118d3 Author: GitHub Action <[email protected]> Date: Thu Apr 4 05:32:28 2024 +0000 Update README.md status badges. commit cec8c45 Author: GitHub Action <[email protected]> Date: Thu Apr 4 05:32:26 2024 +0000 Add test results, prepare README commit 8f1f5e0 Author: GitHub Action <[email protected]> Date: Wed Apr 3 05:35:52 2024 +0000 Update README.md status badges. commit 92d31e4 Author: GitHub Action <[email protected]> Date: Wed Apr 3 05:35:49 2024 +0000 Add test results, prepare README commit ef0151a Author: GitHub Action <[email protected]> Date: Tue Apr 2 05:35:23 2024 +0000 Update README.md status badges. commit 7c1f223 Author: GitHub Action <[email protected]> Date: Tue Apr 2 05:35:21 2024 +0000 Add test results, prepare README commit 0228ec0 Author: GitHub Action <[email protected]> Date: Mon Apr 1 05:38:16 2024 +0000 Update README.md status badges. commit 4c10032 Author: GitHub Action <[email protected]> Date: Mon Apr 1 05:38:14 2024 +0000 Add test results, prepare README commit 842e775 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 03:10:28 2024 -0500 add a failing utc editor test to highlight the bug commit d410f95 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 02:50:07 2024 -0500 enable the utc editor feat/power sorts commit 510cc07 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 01:47:05 2024 -0500 add some guard clauses and cleanup UTIEditor commit ed0af80 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 01:45:52 2024 -0500 cleanup InventoryEditor commit 9b361e5 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 01:45:24 2024 -0500 cleanup section of UTCEditor commit df27066 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 00:18:47 2024 -0500 fix incorrect None returns in UTCEditor also fix the unused batchCacheTPC func commit eaa94fa Author: Benjamin Auquite <[email protected]> Date: Sun Mar 31 00:01:48 2024 -0500 cleanup pathlib overrides commit 211baa6 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 20:37:22 2024 -0500 fix some workflow scripts (sorry for the force push, there's 19 messy commits this'll squash) commit 33d0ee3 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:47:23 2024 -0500 Update tasks.json commit a3328f8 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:41:20 2024 -0500 don't call `_join` on windows. commit bdfeffc Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:34:24 2024 -0500 Update config.py commit 2961f22 Merge: fb3b0a0 57f466d Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:27:21 2024 -0500 Merge branch 'master' of https://github.com/NickHugi/PyKotor into NickHugi/master commit fb3b0a0 Author: Benjamin Auquite <[email protected]> Date: Sat Mar 30 11:27:19 2024 -0500 Update README.md commit 57f466d Author: GitHub Action <[email protected]> Date: Sat Mar 30 05:31:18 2024 +0000 Update README.md status badges. commit a07a43f Author: GitHub Action <[email protected]> Date: Sat Mar 30 05:31:16 2024 +0000 Add test results, prepare README commit 5fcb708 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:49:39 2024 -0500 Update README.md commit 54abae5 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:36:32 2024 -0500 Update release_toolset.yml commit 3c69403 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:13:02 2024 -0500 Update release_toolset.yml commit c7d727c Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:12:21 2024 -0500 Update release_toolset.yml commit 9afb1c2 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:10:55 2024 -0500 Update release_toolset.yml commit f4e76db Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 23:10:10 2024 -0500 Update config.py commit d9e06e9 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:30:45 2024 -0500 Update dlg.py commit b1c3243 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:29:21 2024 -0500 Update dlg.py commit bb028ed Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:29:04 2024 -0500 properly use the new spinbox commit 3f6cc05 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:13:26 2024 -0500 toolset dlg: use proper range for camera animation commit 235d558 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 21:12:49 2024 -0500 Fix critical bug when extracting resources commit e341d0e Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 10:40:49 2024 -0500 improve gff.compare diff output commit 9f50e04 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 11:02:44 2024 -0500 Fix DLG camera angle selection (#97) commit 495a766 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:51:26 2024 -0500 fix incorrect check commit 2c83e58 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:30:19 2024 -0500 disable debug mode commit 3f0c3b5 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 01:26:33 2024 -0500 remove the test environment commit 8590dac Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:32:55 2024 -0500 update the legacy json file commit 9c5ec11 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:26:29 2024 -0500 Update config.py commit b6057b3 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:25:21 2024 -0500 Update config.py commit e55cea2 Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:18:37 2024 -0500 Update config.py commit e7157ff Author: Benjamin Auquite <[email protected]> Date: Fri Mar 29 00:01:06 2024 -0500 fix main repo clearing the cache after fork sload commit b1c6725 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:37:32 2024 -0500 Move a few bleeding-edge fixes before i forget commit 3aa8a56 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:23:53 2024 -0500 Update config.py commit a334524 Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 23:22:08 2024 -0500 Fully open source the compile process (#96) * Create select_update.py * get it runnable for testing * Update select_update.py * Add test results, prepare README * Update README.md status badges. * Add test results, prepare README * Update README.md status badges. * save changes for later * Add test results, prepare README * Update README.md status badges. * add more options * Add test results, prepare README * Update README.md status badges. * Update select_update.py * Add test results, prepare README * Update README.md status badges. * Update select_update.py * Update release_toolset.yml * get an implementation working * Update requirements.txt * fix a few things * Update publish_pykotor.yml * Update release_toolset.yml * Update compile_toolset.ps1 * Update release_toolset.yml * improve `def is_frozen` * change when workflows run. * Update run_and_report_pytests.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * test brew `--no-binaries` * Update release_toolset.yml * fix tag regex in toolset release workflow * Update install_python_venv.ps1 * possibly fix brew's link problem * fix progress hooks & cleanup * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update release_toolset.yml * Update release_toolset.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update publish_pykotor.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * add retry logic. * Update tkinter-like dependency scripts * Update publish_pykotor.yml * don't use brew in tkinter-like dep scripts * potentially fix 3.12 win runner * pwsh: fix infinite loop on ubuntu/debian * Update release_toolset.yml * don't upx compress the ucrt runtime dll's * Update install_python_venv.ps1 * Update release_toolset.yml * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * fix infinite loop on ubuntu * Update release_toolset.yml * fix * Update release_toolset.yml * fix, also implement UpdateDialog * fix set-location not changing back to originalDir * add another upx exclude * Update install_python_venv.ps1 * Update release_toolset.yml * Update release_toolset.yml * Update select_update.py * Update select_update.py --------- Co-authored-by: GitHub Action <[email protected]> commit c9507fc Author: GitHub Action <[email protected]> Date: Thu Mar 28 06:55:29 2024 +0000 Update README.md status badges. commit 01ee6ec Author: GitHub Action <[email protected]> Date: Thu Mar 28 06:55:27 2024 +0000 Add test results, prepare README commit 11fa57b Author: Benjamin Auquite <[email protected]> Date: Thu Mar 28 01:28:33 2024 -0500 Refactor workflows (#92) * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * cleanup requirements * Add test results, prepare README * Update README.md status badges. * test release workflows. * Add test results, prepare README * Update README.md status badges. * fix * Update release_holopatcher.yml * Add test results, prepare README * Update README.md status badges. * ensure archived before release step. * Add test results, prepare README * Update README.md status badges. * Fix `install_powershell.sh` on Arch linux. * Add test results, prepare README * Update README.md status badges. * massively refactor scripts, improve stability&test * Fix debian/ubuntu installs * fix infinite loop due to incorrect arg type * Update install_python_venv.ps1 * Update run_and_report_pytests.yml * Update run_and_report_pytests.yml * handle the curl redirects correctly * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * add a log to see what the heck is breaking. * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * Update install_python_venv.ps1 * fix * Update run_and_report_pytests.yml * potentially fix mismatched x86/x64 * github runners x86 apparently are still 64-bit * fix the env * Add test results, prepare README * Update README.md status badges. * Update install_python_venv.ps1 * Add test results, prepare README * Update README.md status badges. * Update publish_pykotor.yml * Add test results, prepare README * Update README.md status badges. --------- Co-authored-by: GitHub Action <[email protected]> commit 06247a8 Author: GitHub Action <[email protected]> Date: Thu Mar 28 00:34:09 2024 +0000 Update README.md status badges. commit 3ca2d7a Author: GitHub Action <[email protected]> Date: Thu Mar 28 00:34:06 2024 +0000 Add test results, prepare README commit 105d237 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 19:19:59 2024 -0500 cleanup. for the billionth time. Repo is enormous. commit c24aa2c Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:44:13 2024 +0000 Update README.md status badges. commit 3f22707 Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:44:11 2024 +0000 Add test results, prepare README commit 8520aa6 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:24:45 2024 -0500 cleanup commit ea772a0 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:21:07 2024 -0500 Properly cleanup the toolset on exit. commit 5d247b8 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:20:18 2024 -0500 #95 (continuation of #94) commit a3efdad Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 17:16:43 2024 -0500 Update path.py (#94) commit 16e252d Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:10:03 2024 +0000 Update README.md status badges. commit fc1cc87 Author: GitHub Action <[email protected]> Date: Wed Mar 27 22:10:01 2024 +0000 Add test results, prepare README commit 8c10be7 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 16:58:29 2024 -0500 Conditional concurrent resource loading of installation (#93) as reported in #bugs, the multithreaded installation can be dramatically slower on some systems. Disable by default. commit d257bc3 Author: GitHub Action <[email protected]> Date: Wed Mar 27 10:53:15 2024 +0000 Update README.md status badges. commit b74cdb2 Author: GitHub Action <[email protected]> Date: Wed Mar 27 10:53:13 2024 +0000 Add test results, prepare README commit 89cb080 Author: Benjamin Auquite <[email protected]> Date: Wed Mar 27 05:22:15 2024 -0500 fix incorrect restype using of TPCEditor commit ad1a8b6 Author: GitHub Action <[email protected]> Date: Tue Mar 26 14:11:04 2024 +0000 Update README.md status badges. commit 3a171ac Author: GitHub Action <[email protected]> Date: Tue Mar 26 14:11:02 2024 +0000 Add test results, prepare README commit 79407c8 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:42:58 2024 -0500 logging commit 0926953 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:27:41 2024 -0500 Update requirements-dev.txt commit b5f3747 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:25:58 2024 -0500 more logging commit 6551a05 Author: GitHub Action <[email protected]> Date: Tue Mar 26 13:22:08 2024 +0000 Update README.md status badges. commit fbbd148 Author: GitHub Action <[email protected]> Date: Tue Mar 26 13:22:06 2024 +0000 Add test results, prepare README commit f3ccc42 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:07:07 2024 -0500 Update registry.py commit e5ecc9f Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:06:32 2024 -0500 fix critical bug with find_software_key commit 98361b7 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 08:04:48 2024 -0500 cleanup commit fce2790 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:49:55 2024 -0500 cleanup some things, implement the logger more commit f2db1f2 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:32:11 2024 -0500 Update registry.py commit 81e0736 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:29:36 2024 -0500 Update registry.py commit ebbae0d Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:24:08 2024 -0500 Fix missing exception object in catch statement commit 172c547 Author: Benjamin Auquite <[email protected]> Date: Tue Mar 26 07:23:55 2024 -0500 cleanup some logging commit 7717a2c Author: GitHub Action <[email protected]> Date: Tue Mar 26 02:21:08 2024 +0000 Update README.md status badges. commit cb6cfef Author: GitHub Action <[email protected]> Date: Tue Mar 26 02:21:06 2024 +0000 Add test results, prepare README commit 4c6c214 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 21:08:50 2024 -0500 fix some typing commit 974c9ca Author: GitHub Action <[email protected]> Date: Mon Mar 25 18:59:48 2024 +0000 Update README.md status badges. commit 06c7d8e Author: GitHub Action <[email protected]> Date: Mon Mar 25 18:59:46 2024 +0000 Add test results, prepare README commit 9bc9a28 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 13:28:39 2024 -0500 cleanup module designer commit eda77db Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 13:02:39 2024 -0500 `ruff check .` commit 7f298a0 Author: Benjamin Auquite <[email protected]> Date: Mon Mar 25 12:59:03 2024 -0500 implement partials for the logger commit ef393d1 Author: GitHub Action <[email protected]> Date: Mon Mar 25 00:43:14 2024 +0000 Update README.md status badges. commit 7290bec Author: GitHub Action <[email protected]> Date: Mon Mar 25 00:43:11 2024 +0000 Add test results, prepare README commit bf4c399 Author: Benjamin Auquite <[email protected]> Date: Sun Mar 24 19:06:02 2024 -0500 cleanup nwnnsscomp abstraction commit 9a5fb1f Author: GitHub Action <[email protected]> Date: Sun Mar 24 17:25:22 2024 +0000 Update README.md status badges. commit e579da2 Author: GitHub Action <[email protected]> Date: Sun Mar 24 17:25:20 2024 +0000 Add test results, prepare README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are seven Camera angles and they start from 0, so this check is incorrect:
should be checking if it's == 7, or better yet check if it's greater than 7. Not sure why this check exists in the first place but w/e
Without this change it's impossible to select 'Static Camera'