Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# --> C++ #782

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
62482fa
Use C++ Template
nlogozzo Jun 16, 2024
6f8172c
GNOME - Cleanup
nlogozzo Jun 16, 2024
81626f6
Update mainwindow.cpp
nlogozzo Jun 16, 2024
f363fd0
Shared - Config + Disclaimer
nlogozzo Jun 17, 2024
936b47d
All - Implement Global Configuration
nlogozzo Jun 18, 2024
e006025
Shared/WinUI - Download History
nlogozzo Jun 18, 2024
f9985fe
Shared - Cleanup
nlogozzo Jun 18, 2024
46f8176
Shared/WinUI - Add DownloaderOptions Model
nlogozzo Jun 20, 2024
b4a706b
Shared - Add DownloadOptions, DownloadProgressStatus, and DownloadPro…
nlogozzo Jun 21, 2024
ffdda41
Shared - Add Media & UrlInfo Models
nlogozzo Jun 21, 2024
cab8884
Shared - Load Python + NetworkMonitor
nlogozzo Jun 21, 2024
ebf50fc
All - Load vcpkg Python Environment via CMake
nlogozzo Jun 22, 2024
89d1e5b
Better Docs + Update ytdlp
nlogozzo Jun 24, 2024
f00de29
Update dependencies
nlogozzo Jun 24, 2024
6a8404f
GNOME - Fix Linux Build
nlogozzo Jun 24, 2024
30871c7
Update preferencesdialog.cpp
nlogozzo Jun 24, 2024
421aec3
Update libnick
nlogozzo Jun 26, 2024
b3dbe6f
Merge branch 'main' into cpp
nlogozzo Jun 27, 2024
a97679a
Update Deps + Build WinUI Installer With CI
nlogozzo Jun 28, 2024
1cdec6c
Update yt-dlp
nlogozzo Jul 3, 2024
5354785
Shared - Implement UrlInfo + Testing Framework
nlogozzo Jul 4, 2024
fa617e8
Linux - Update libnick
nlogozzo Jul 4, 2024
021ac06
GNOME - Implement NavigationSplitView
nlogozzo Jul 4, 2024
d691ca8
Shared - Cleanup
nlogozzo Jul 4, 2024
7903048
snap: update for core24
soumyaDghosh Jul 5, 2024
bb0bda8
GNOME - Implement History
nlogozzo Jul 5, 2024
e613d6e
Merge branch 'cpp' into snap-cpp
nlogozzo Jul 5, 2024
24ed640
Shared - Allow Length For DownloadHistory
nlogozzo Jul 6, 2024
485aebb
GNOME - Pass Arguments to GApplication
nlogozzo Jul 6, 2024
c7cc3d6
Merge branch 'snap-cpp' into cpp
nlogozzo Jul 6, 2024
9f8b9eb
Update snap.yml
nlogozzo Jul 6, 2024
6b8aa1e
GNOME - Fix Window Not Showing
nlogozzo Jul 7, 2024
5a26cec
Shared - Start Download Model
nlogozzo Jul 7, 2024
17b9c6d
Shared - Install Parabolic ytdlp Plugin
nlogozzo Jul 8, 2024
8ed0a6f
WinUI - Ensure ffmpeg and aria2 are installed
nlogozzo Jul 8, 2024
ebb55cd
Update dependencies
nlogozzo Jul 8, 2024
4e643dc
Update libnick
nlogozzo Jul 9, 2024
2f9bff8
Update yt-dlp
nlogozzo Jul 9, 2024
743e621
Shared - Fix Configuration Fix on Linux
nlogozzo Jul 9, 2024
3c87a7a
Shared - Implement Download::runDownload()
nlogozzo Jul 10, 2024
5fca97d
Use `yt-dlp` Executable Instead of Embedded Python (#789)
nlogozzo Jul 12, 2024
99a2789
Shared - Build Fixes
nlogozzo Jul 12, 2024
eb21685
Shared - Implement DownloadManager
nlogozzo Jul 12, 2024
4f5acbc
Shared - Improved DownloadManager Performance + Logging
nlogozzo Jul 12, 2024
0eb23c9
WinUI - Better History Page
nlogozzo Jul 14, 2024
f761a9a
Tests - Use DownloadManager in DownloadTest
nlogozzo Jul 14, 2024
975f7e6
Shared - Add PreviousDownloadOptions Model
nlogozzo Jul 14, 2024
c8a20d2
All - Blank AddDownloadDialog UI
nlogozzo Jul 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 0 additions & 12 deletions .config/dotnet-tools.json

This file was deleted.

9 changes: 3 additions & 6 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
[*.{sln,resx}]
indent_style = tab

[*.{cs,sh,py,json,page,cake}]
[*.{h,cpp,py,json,page,txt}]
indent_style = space
indent_size = 4

[*.{csproj,xml,css,md,blp,yml}]
[*.{xml,css,md,blp,yml}]
indent_style = space
indent_size = 2
indent_size = 2
4 changes: 1 addition & 3 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# Auto detect text files and perform LF normalization
* text eol=lf
*.csproj eol=crlf
*.sln eol=crlf
*.png binary
*.jpg binary
*.ico binary
*.pdf binary
*.exe binary
# Exclude Docs From Stats
NickvisionTubeConverter.Shared/Docs/** linguist-documentation
docs/** linguist-documentation
8 changes: 3 additions & 5 deletions .github/workflows/flatpak.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:
id-token: write
contents: read
jobs:
flatpak:
gnome-flatpak:
name: "GNOME on Flatpak"
runs-on: ubuntu-latest
if: ${{ github.event.pull_request.user.login != 'weblate' }}
Expand All @@ -22,13 +22,11 @@ jobs:
arch: [x86_64]
fail-fast: false
steps:
- uses: actions/checkout@v3
with:
submodules: recursive
- uses: actions/checkout@v4
- uses: flatpak/flatpak-github-actions/[email protected]
with:
bundle: org.nickvision.tubeconverter.flatpak
manifest-path: flatpak/org.nickvision.tubeconverter.json
cache-key: flatpak-builder-${{ github.sha }}
arch: ${{ matrix.arch }}
restore-cache: true
restore-cache: true
28 changes: 9 additions & 19 deletions .github/workflows/snap.yml
Original file line number Diff line number Diff line change
@@ -1,37 +1,27 @@
on:
push:
branches: [ "main" ]
branches: ["main"]
pull_request:
branches: [ "main" ]
types: [ "review_requested", "ready_for_review" ]
branches: ["main"]
types: ["review_requested", "ready_for_review"]
workflow_dispatch:
name: Snap
permissions:
id-token: write
contents: read
jobs:
snap:
gnome-snap:
name: "GNOME on Snap"
runs-on: ubuntu-latest
steps:
- name: Checkout Git repository
uses: actions/checkout@v4
with:
submodules: recursive
- name: Build Snap
- uses: actions/checkout@v4
- name: Build
uses: snapcore/action-build@v1
id: snapcraft-build
with:
snapcraft-args: "-v"
snapcraft-args: "--verbosity debug"
snapcraft-channel: "edge"
- uses: actions/upload-artifact@v4
with:
name: ${{ steps.snapcraft-build.outputs.snap }}
name: tube-converter-snap
path: ${{ steps.snapcraft-build.outputs.snap }}
- name: Upload and release Parabolic Snap
uses: snapcore/action-publish@v1
if: ${{ github.event_name != 'pull_request' }}
env:
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.STORE_LOGIN }}
with:
snap: ${{ steps.snapcraft-build.outputs.snap }}
release: ${{'edge'}}
6 changes: 3 additions & 3 deletions .github/workflows/spelling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
codespell:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: codespell-project/actions-codespell@master
with:
check_filenames: true
skip: cargo-sources.json,.git,*.svg,*.html,*.js,*.po,*.pot,*.page
ignore_words_list: gir,te
skip: cargo-sources.json,.git,*.svg,*.html,*.js,*.po,*.pot,*.page,*.map,sqlite3.h,sqlite3.c,pch.h,CONTRIBUTING.md
ignore_words_list: gir
45 changes: 45 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
types: [ "review_requested", "ready_for_review" ]
workflow_dispatch:
name: Test
permissions:
id-token: write
contents: read
env:
GITHUB_ACTIONS: true
VCPKG_ROOT: ${{github.workspace}}/vcpkg
jobs:
windows:
name: "Test on Windows"
runs-on: windows-latest
if: ${{ github.event.pull_request.user.login != 'weblate' }}
steps:
- name: "Checkout"
uses: actions/checkout@v4
with:
submodules: recursive
- name: "Setup Environment"
run: |
mkdir build
choco install ffmpeg
choco install aria2
- name: "Vcpkg"
uses: johnwason/vcpkg-action@v6
id: vcpkg
with:
pkgs: boost-date-time libnick
triplet: x64-windows
revision: 5f502b165027bbede86ff2c5316334e3398bc519
token: ${{ secrets.GITHUB_TOKEN }}
github-binarycache: true
- name: "Build"
working-directory: ${{github.workspace}}/build
run: |
cmake -G "Visual Studio 17 2022" .. -DBUILD_TESTING=ON -DBACKEND_ONLY=ON
cmake --build . --config Release
- name: Test
run: ${{github.workspace}}/build/libparabolic/Release/libparabolic_test.exe
61 changes: 61 additions & 0 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
types: [ "review_requested", "ready_for_review" ]
workflow_dispatch:
name: Windows
permissions:
id-token: write
contents: read
env:
GITHUB_ACTIONS: true
VCPKG_ROOT: ${{github.workspace}}/vcpkg
jobs:
build:
name: "Build on x64"
runs-on: windows-latest
if: ${{ github.event.pull_request.user.login != 'weblate' }}
steps:
- name: "Checkout"
uses: actions/checkout@v4
with:
submodules: recursive
- name: "Setup Environment"
run: mkdir build
- name: "Vcpkg"
uses: johnwason/vcpkg-action@v6
id: vcpkg
with:
pkgs: boost-date-time libnick
triplet: x64-windows
revision: 5f502b165027bbede86ff2c5316334e3398bc519
token: ${{ secrets.GITHUB_TOKEN }}
github-binarycache: true
- name: "Build"
working-directory: ${{github.workspace}}/build
run: |
cmake -G "Visual Studio 17 2022" .. -DBUILD_TESTING=OFF
cmake --build . --config Release
- name: "Create Installer"
working-directory: ${{github.workspace}}
run: |
choco install wget
choco install innosetup
wget https://aka.ms/vs/17/release/vc_redist.x64.exe -O vc_redist.x64.exe
wget https://aka.ms/windowsappsdk/1.5/1.5.240627000/windowsappruntimeinstall-x64.exe -O windowsappruntimeinstall-x64.exe
wget https://github.com/yt-dlp/yt-dlp/releases/download/2024.07.09/yt-dlp.exe -O yt-dlp.exe
wget https://github.com/aria2/aria2/releases/download/release-1.37.0/aria2-1.37.0-win-64bit-build1.zip -o aria2.zip
wget https://github.com/GyanD/codexffmpeg/releases/download/2024-07-07-git-0619138639/ffmpeg-2024-07-07-git-0619138639-full_build.zip -o ffmpeg.zip
powershell -command "Expand-Archive -Force 'aria2.zip'"
mv aria2/aria2-1.37.0-win-64bit-build1/aria2c.exe aria2c.exe
mv ffmpeg/ffmpeg-2024-07-07-git-0619138639-full_build/bin/ffmpeg.exe ffmpeg.exe
mv ffmpeg/ffmpeg-2024-07-07-git-0619138639-full_build/bin/ffprobe.exe ffprobe.exe
mv ffmpeg/ffmpeg-2024-07-07-git-0619138639-full_build/bin/ffplay.exe ffplay.exe
iscc inno/setup.iss
- name: Upload
uses: actions/upload-artifact@v4
with:
path: ${{github.workspace}}/inno/NickvisionParabolicSetup.exe
name: Windows-x64-Release
48 changes: 0 additions & 48 deletions .github/workflows/winui.yml

This file was deleted.

Loading