Fix primefaces#12577: Screenreader improve hidden accessible (primefa…

…ces#12583)
NicolaIsotta · Sep 12, 2024 · d821a98 · d821a98
1 parent a8b7ca7
commit d821a98
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 19 deletions.
diff --git a/primefaces/src/main/resources/META-INF/resources/primefaces/core/core.css b/primefaces/src/main/resources/META-INF/resources/primefaces/core/core.css
@@ -1,10 +1,3 @@
-.ui-helper-hidden-accessible input,
-.ui-helper-hidden-accessible select {
-    -webkit-transform: scale(0); 
-    -moz-transform: scale(0); 
-    transform: scale(0);
-}
-
 .ui-shadow {
     -moz-box-shadow: 0px 5px 10px rgba(0,0,0,0.8);
     -webkit-box-shadow: 0px 5px 10px rgba(0,0,0,0.8);

diff --git a/...efaces/src/main/resources/META-INF/resources/primefaces/jquery/jquery.ui.pfextensions.css b/...efaces/src/main/resources/META-INF/resources/primefaces/jquery/jquery.ui.pfextensions.css
@@ -3,22 +3,22 @@
     padding: 0.3em;
 }
 
-.ui-icon { 
-    display: block; 
-    vertical-align: baseline;
+.ui-icon {
+    display: block;
     margin-top: 0px;
 }
 
-/* https://stackoverflow.com/a/62109988/502366 */
+/* Modern override for all browsers and screenreaders */
 .ui-helper-hidden-accessible {
-    border: 0 !important;
-    padding: 0 !important;
-    margin: -1px !important;
+    border: unset;
+    clip: unset;
+    height: unset;
+    margin: unset;
+    overflow: unset;
+    padding: unset;
+    width: unset;
     position: absolute !important;
-    height: 1px !important;
-    width: 1px !important;
-    overflow: hidden !important;
-    clip: rect(1px, 1px, 1px, 1px) !important; /* Legacy Browsers */
-    clip-path: inset(50%) !important; /* Modern Browsers */
+    pointer-events: none !important;
+    opacity: 0 !important;
     white-space: nowrap !important;
 }