-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Spearman Correlation for similarities module. #168
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! It looks pretty good even though I haven't checked it in details yet. For the tests, take a look at how to use pytest and take inspiration from the test_similarities module. It would also be helpful to have some simple benchmark comparing Spearman with other metrics in terms of RMSE and computation time |
I'll run the tests, thanks a lot. |
This looks good and I'd like to merge it but could you please write a few tests in the You'll also need to update the |
I am a bit short of time due to my exams. Shall I write the tests after my exams? I shall modify the AlgoBase.compute_similarities now itself though. |
No worries there's absolutely no rush! |
Hi,
I have added a function to implement spearman correlation in the similarities module. I am very new to Open source contributions, please do bear with any errors.
I have followed the steps as in the Contribution Guidelines. If I am missing anything, do let me know. Also I am unaware on how to test my code. Would require some guidance.