fix: only increment the current_concurrency counter if the job has max_concurrency set
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok but conflicted with your last change that I just merged. I'll approve and merge once fixed. |
…`max_concurrency` set Seems to have been a small oversight when popping idempotent jobs from the queue on Redis. Fixes: Issue NicolasLM#15
|
Done. |
0xDEC0DE
changed the title
current_concurrency counter if the job max max_concurrency setcurrent_concurrency counter if the job has max_concurrency set
bigjools
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to have been a small oversight when popping idempotent jobs from the queue on Redis.
Fixes: Issue #15