-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zib-AnatomicalLocation #6
base: main
Are you sure you want to change the base?
Conversation
…mmy Problem example
…le. Improved guidance.
…its of the profiles based on QA
Reworked the profiles by moving the location binding from Tested this approach using a dummy profile and multiple examples:
Also, the QA gives a "Fail: "check nl-core overrides" --> but I don't understand why... @pieter-edelman-nictiz would you be willing to have another look? |
The QA error is quite trivial; in the nl-core profile, you should override the mention of “zib-” profile to the “nl-core-” profile. |
When generating a snapshot in Forge or using the HL7 Validator, the binding from the dataset profile is ignored and reverts to the default from the base resource. |
@pieter-edelman-nictiz , thanks for checking. I will investigate further... I posed this point on zulip. Might want to include this then to our list of things to check. If it doesn't work out in before publication time, we can revert back to the 'old' way and include the binding in the host profiles. Agree? |
…files to include binding in host profile Reload terminology and remove dummy profile
@pieter-edelman-nictiz / @LuudSlagter - could one of you review this PR?
|
Sorry about the previous to send message. I updated the profile by mapping Location on a slice of Lastly, I added documentation why we choose this profiling approach. It is on a comment field of |
# Conflicts: # release-notes.md
zib/StructureDefinitions/zib-AnatomicalLocation-BodyStructure.xml
Outdated
Show resolved
Hide resolved
…ems bound to location if a code value is used
…with guidance on binding the location valueset in host profile with extensible binding strenght
# Conflicts: # release-notes.md
@pieter-edelman-nictiz good to go? |
# Conflicts: # release-notes.md
Initial commit of new profiling proposal based on recent discussions (https://nictiz.atlassian.net/browse/ZIBFHIR2024-173).