Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the compatibility of XML-RPC library with PHP 8 - Orig PR6264 #2

Merged
merged 14 commits into from
Dec 20, 2024

Conversation

NielBuys
Copy link
Owner

@NielBuys NielBuys commented Dec 20, 2024

Merging pull request: bcit-ci#6264

@NielBuys
Copy link
Owner Author

Fixed warnings bcit-ci#6306

@NielBuys NielBuys merged commit e7173c9 into develop Dec 20, 2024
132 checks passed
@NielBuys NielBuys deleted the tasks/PR6264 branch December 20, 2024 19:16
@jamieburchell
Copy link

@NielBuys Heads up, the tests don't appear to run on PHPUnit 10+:

$ composer run test:coverage
> @putenv XDEBUG_MODE=coverage
> phpunit --color=always --coverage-text --configuration tests/phpunit.xml
PHP Fatal error:  Cannot override final method PHPUnit\Framework\TestCase::runBare() in /home/jamie/projects/CodeIgniter/tests/mocks/ci_testcase.php on line 349

Fatal error: Cannot override final method PHPUnit\Framework\TestCase::runBare() in /home/jamie/projects/CodeIgniter/tests/mocks/ci_testcase.php on line 349
Script phpunit --color=always --coverage-text --configuration tests/phpunit.xml handling the test:coverage event returned with error code 255

@NielBuys
Copy link
Owner Author

@jamieburchell Thanks I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants