Selective activation time update #3122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will open another to address this better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a hard reset of a mod transmitter, the read time stamp becomes a very large value. I am not sure. But, this could be because of a format mismanagement of a negative number, turning a very small negative value into a very large positive value (6214 days or 17 years)!
The activation time calculated from that goes back to 2006. When this is written into the persistent store, resulting transmitter days value becomes invalid (unknown).
This PR avoids writing into the persistent store an activation time that is so far back in the past.
Tests show that the lock situation reported by users (#3078) does not happen any longer after this PR.