Remove setting Authenticate before each read #3183
Conversation
|
So there are a number of problems with this PR. I will go through them below:
Having said that I think it is okay to remove this setting as it is needless clutter for something users shouldn't change and applies to an obsolete collector. |
|
Thanks, I will fix it. |
|
I'm not clear about your direction. You say:
That's what I wanted to do. To remove the setting. |
|
Are you saying I should leave IdempotentMigrations alone and not change it because this setting doesn't really exist? |
|
However, please note that I see this setting used in wear. |
|
Hi, please re-read my previous comment. Point 1 explains why the PR wont do you you intend it to do and Point 2 explains that I don't believe there are currently any users affected by the problem you mention as the rationale - but I am not against removing the setting as it is not needed but this PR doesn't do that properly so please re-check your work. |
|
@jamorham I have a screenshot, in the very first post, that shows that this PR removes the setting, which is the intent. |
|
I did recheck my work. I just did again. 7 of the 11 are wear. In this PR, I am deleting the first, which removes the setting. Please tell me what I am overlooking. |
|
In these PRs, where I remove a setting that is not needed any longer, I follow your approach here as you directed me: Please tell me what I have done here that is not the same. Or what I have not done that is needed. |
| @@ -147,6 +147,7 @@ private static void legacySettingsFix() { | |||
| Pref.setBoolean("use_ob1_g5_collector_service", true); | |||
| Pref.setBoolean("ob1_g5_fallback_to_xdrip", false); | |||
| Pref.setBoolean("always_unbond_G5", false); | |||
| Pref.setBoolean("authentificate_before_reading", true); | |||
There was a problem hiding this comment.
How did I miss that?!
Thanks
| @@ -2493,6 +2493,7 @@ private void removeLegacyPreferences() { | |||
| // removePreferenceFromCategory("use_ob1_g5_collector_service", "ob1_options"); | |||
| // removePreferenceFromCategory("ob1_g5_fallback_to_xdrip", "ob1_options"); | |||
| // removePreferenceFromCategory("always_unbond_G5", "ob1_options"); | |||
| // removePreferenceFromCategory("authentificate_before_reading", "ob1_options"); | |||
|
Corrected the keys. Thanks for catching that. |
This PR permanently enables the setting "Authenticate before each read" on the G5/G6/Dex1 Debug Settings page, and removes the setting.
There are individuals who disable it and wonder why they have trouble.
This image shows what the settings page looks after:
Selecting different Libre options, the logs show the exception the same as selecting G6.
