Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire allow OB1 initiate bonding #3575

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Jul 19, 2024

This PR will remove another setting from the Dex Settings page.

I cannot think of a scenario when one may need to disable this. Of course there is a case where you don't intend to connect to a device. But, why would you enter the transmitter ID if you don't intend to connect. I mean you can avoid xDrip attempting to connect by just disabling collector.

Considering there is an alternative way to accomplish the same thing, I hope you allow this setting to be removed.
A considerable percentage of the requests for help is related to wrong settings on this page.
Even though we have a guide that shows the correct settings, incorrect settings still appear on facebook requests for help.
So, I wish to minimize the number of settings on this page.

Is there a scenario in which we may need to disable this setting?

Thanks

@Navid200
Copy link
Collaborator Author

This is what the page will look like after this for a G6.

Screenshot_20240718-202632

@jamorham
Copy link
Collaborator

jamorham commented Aug 7, 2024

I don't think you full understand how this works. Either end of a bluetooth connection can initiate the bonding. There is designed to be some adaptability in the code for this although much of it is moot after google changed bluetooth bonding behavior during covid. I do agree with removing the setting and forcing it to true but the code paths should remain in case we need to bring back that flexibility.

@jamorham jamorham merged commit f0ba4ed into NightscoutFoundation:master Aug 7, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_07_18 branch August 7, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants