Scan QR code from image file #3593
Conversation
|
After this PR, tapping on auto config, will bring you to a new page shown below. Tapping on the button at the top does exactly what auto config button does now. |
|
Tapping on the button at the bottom on the new page to scan from an image file, the user will see a page like this:
It allows user to navigate through the different folders in storage to find the image file. |
|
I just tested this using a Pixel (Android 7) virtual machine and it worked to confirm that it works on Android 7 as well. |
| @@ -39,6 +39,10 @@ | |||
| <string name="pref_header_cloud_storage">Cloud Storage</string> | |||
| <string name="auto_configure_title">Auto configure</string> | |||
| <string name="prefs_auto_config_summary">Auto configure using a barcode.</string> | |||
| <string name="auto_config_cam_title">Scanner</string> | |||
| <string name="auto_config_cam_summary">Scan a QR code with your mobile (recommended)</string> | |||
There was a problem hiding this comment.
shouldn't you mention "camera" here?
There was a problem hiding this comment.
I spent some time with ChatGPT for these. But, I see your point.
The problem is if I focus on the meaning of the sentence, saying scan with your camera, it may be taken as take a camera, not your phone, out of your pocket and use it to scan.
What if I change that to the following?
Scan a QR code with your mobile camera
There was a problem hiding this comment.
Sorry, I even confused myself. I will think about this and improve the strings.
There was a problem hiding this comment.
How about this?
Title: Scanner (camera)
Summary: Scan a QR code with your mobile camera
| android:key="auto_configure" | ||
| android:summary="@string/auto_config_cam_summary" | ||
| android:title="@string/auto_config_cam_title" /> | ||
| <Preference |
There was a problem hiding this comment.
Can't we just have these one underneath each other in the same way as other preferences?
There was a problem hiding this comment.
Definitely! I can do that.
The only reason I did this was because I wanted to give more prominence to the existing scheme. I mean if user can use camera, they should never use the second option.
That's the only reason I did this.
There was a problem hiding this comment.
I have made both of those changes.
This is what it looks like now:
There was a problem hiding this comment.
I'll probably keep the QR code on my storage somewhere and almost always use that instead of Camera. That way I don't have to hunt for the code every time I need to reconfigure my app for G7
There are times a QR code scan is not possible.
This is an example: #2960
This PR adds a new capability allowing the user to scan the QR code from a saved image file.
Tests
Android 8, 9, 11 and 15 have been tested.
The OB1 debug QR code, a saved settings QR code from xDrip, and the G7 QR code have been used for tests.
If you have any comments for improving the new strings, please do not hesitate to tell me.
If you see anything in the code that you don't like, please tell me.
Thanks