-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Features for Diacon P8 Insulin Pen #3783
base: master
Are you sure you want to change the base?
Conversation
Background sync added
Removed connection toast due to excessive display.
Removed connection toast due to excessive display.
Removed connection toast due to excessive display.
Hello, thanks for this submission. Can you please give some more details on the testing which has been done to confirm accurate operation? Also please look at the merge conflicts and resolve them. |
I cannot review. You can ignore my comments. I'm just making comments here as an observer. My understanding of how translations are done in this project is that all strings are originally only entered in English. Then, at least two translators are needed for each language in Crowdin. One can enter a suggestion. The other will have to proof read/verify. This means that no translation is done only by one person. This reduces chances of errors considering the reviewer here (xDrip code review, not language review) does not speak all languages. When injecting a unit to empty the air inside the needle, is there a mechanism for not logging that in xDrip as a real injection? Does this code use the existing insulin types in xDrip? Or, does it introduce a different set of insulin types? If the latter, wouldn't this result in code duplication and possibly errors in the future? I see hardly any comments in the code. Is that intentional? Please don't make any changes. As I said, I am not the reviewer. You can ignore all my comments. |
This PR introduces key features related to the Diaconn P8 Insulin Pen.
Below are the updates and screen changes included in this release:
Key Changes
1. Added Diaconn P8 Menu
2. Pen Connection (Pairing) Feature
3. Sound Playback During Pen log transfer
4. Automatic Synchronization
Screen Details
Pen Menu Addition Screen
Diaconn P8 menu Screen
Diaconn P8 Paring
Includes a UI to support the pairing process for the Diacon P8 insulin pen.
Looking forward to your review! 😊