Skip to content

fix: fix invalid name for default solution #54

fix: fix invalid name for default solution

fix: fix invalid name for default solution #54

Status Success
Total duration 2m 51s
Artifacts 2

build.yml

on: pull_request
Matrix: build
Push GitHub Container Registry
0s
Push GitHub Container Registry
Push GitHub Packages
0s
Push GitHub Packages
Push NuGet Packages
0s
Push NuGet Packages
Fit to window
Zoom out
Zoom in

Annotations

55 warnings
Build-ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/[email protected], actions/setup-dotnet@v1, actions/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build-ubuntu-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/setup-dotnet@v1, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build-ubuntu-latest
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaResource.cs#L36
Change 'List<string>' in 'OllamaResource.Models' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L198
'CancellationTokenSource.Cancel()' synchronously blocks. Await 'CancellationTokenSource.CancelAsync()' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849)
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L124
Modify 'DownloadModel' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L20
'OllamaLifecycleHook' contains field 'cancellationTokenSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'OllamaLifecycleHook' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
Build-ubuntu-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'OnProgress' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-ubuntu-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'Nodes' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-ubuntu-latest: src/Dependify.Core/Serializers/MermaidC4Serializer.cs#L16
Dereference of a possibly null reference.
Build-ubuntu-latest: src/Dependify.Core/MsBuildService.cs#L9
Provide an overridable implementation of Dispose(bool) on 'MsBuildService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build-ubuntu-latest: src/Dependify.Core/Serializers/MermaidC4Serializer.cs#L29
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
Build-ubuntu-latest
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaResource.cs#L36
Change 'List<string>' in 'OllamaResource.Models' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L198
'CancellationTokenSource.Cancel()' synchronously blocks. Await 'CancellationTokenSource.CancelAsync()' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849)
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L124
Modify 'DownloadModel' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
Build-ubuntu-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L20
'OllamaLifecycleHook' contains field 'cancellationTokenSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'OllamaLifecycleHook' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
Build-ubuntu-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'OnProgress' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-ubuntu-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'Nodes' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-ubuntu-latest: src/Dependify.Core/Serializers/MermaidC4Serializer.cs#L16
Dereference of a possibly null reference.
Build-ubuntu-latest: src/Dependify.Core/MsBuildService.cs#L9
Provide an overridable implementation of Dispose(bool) on 'MsBuildService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build-ubuntu-latest: src/Dependify.Core/SolutionRegistry.cs#L7
Type 'SolutionRegistry' owns disposable field(s) 'subject' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001)
Build-ubuntu-latest: tests/Dependify.Core.Tests/MsBuildServiceTests.cs#L26
Possible null reference argument for parameter 'solution' in 'DependencyGraph MsBuildService.AnalyzeReferences(SolutionReferenceNode solution, MsBuildConfig config)'.
Build-ubuntu-latest: tests/Dependify.Core.Tests/MsBuildServiceTests.cs#L9
Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)
Build-ubuntu-latest: tests/Dependify.Core.Tests/MsBuildServiceTests.cs#L30
Use the "Count" property instead of Enumerable.Count() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1829)
Build-ubuntu-latest
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build-ubuntu-latest
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build-windows-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/[email protected], actions/setup-dotnet@v1, actions/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build-windows-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/setup-dotnet@v1, actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build-windows-latest
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build-windows-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'OnProgress' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-windows-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'Nodes' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-windows-latest: src/Dependify.Core/Serializers/MermaidC4Serializer.cs#L16
Dereference of a possibly null reference.
Build-windows-latest: src/Dependify.Core/MsBuildService.cs#L9
Provide an overridable implementation of Dispose(bool) on 'MsBuildService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build-windows-latest: src/Dependify.Core/MsBuildService.cs#L90
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
Build-windows-latest: src/Dependify.Core/MsBuildService.cs#L97
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
Build-windows-latest: src/Dependify.Core/SolutionRegistry.cs#L7
Type 'SolutionRegistry' owns disposable field(s) 'subject' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001)
Build-windows-latest: src/Dependify.Core/MsBuildService.cs#L165
Modify 'MsBuildService.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build-windows-latest: src/Dependify.Core/MsBuildService.cs#L165
Change MsBuildService.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
Build-windows-latest
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build-windows-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaResource.cs#L36
Change 'List<string>' in 'OllamaResource.Models' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
Build-windows-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L198
'CancellationTokenSource.Cancel()' synchronously blocks. Await 'CancellationTokenSource.CancelAsync()' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849)
Build-windows-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L124
Modify 'DownloadModel' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
Build-windows-latest: src/Dependify.Aspire.Hosting.Ollama/OllamaLifecycleHook.cs#L20
'OllamaLifecycleHook' contains field 'cancellationTokenSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'OllamaLifecycleHook' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
Build-windows-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'OnProgress' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-windows-latest: src/Dependify.Core/SolutionRegistry.cs#L23
Non-nullable property 'Nodes' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build-windows-latest: src/Dependify.Core/Serializers/MermaidC4Serializer.cs#L16
Dereference of a possibly null reference.
Build-windows-latest: src/Dependify.Core/MsBuildService.cs#L9
Provide an overridable implementation of Dispose(bool) on 'MsBuildService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build-windows-latest: src/Dependify.Core/Serializers/MermaidC4Serializer.cs#L34
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
Build-windows-latest
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build-windows-latest
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build-windows-latest: tests/Dependify.Core.Tests/MsBuildServiceTests.cs#L26
Possible null reference argument for parameter 'solution' in 'DependencyGraph MsBuildService.AnalyzeReferences(SolutionReferenceNode solution, MsBuildConfig config)'.
Build-windows-latest: tests/Dependify.Core.Tests/MsBuildServiceTests.cs#L9
Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)
Build-windows-latest: tests/Dependify.Core.Tests/MsBuildServiceTests.cs#L30
Use the "Count" property instead of Enumerable.Count() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1829)
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "ubuntu-latest", "windows-latest". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
ubuntu-latest Expired
63.5 MB
windows-latest Expired
63.9 MB