Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keycloak SDK get Groups #49

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Keycloak SDK get Groups #49

merged 6 commits into from
Oct 25, 2023

Conversation

sharwinbobde
Copy link
Contributor

Able to access groups along with group attributes

@sharwinbobde
Copy link
Contributor Author

@NikiforovAll can you check the changes out? I tested the exported package and works as desired.
If the changes are compliant by the repository's standards then Ill continue to making the POST/PUT endpoints for the groups.

NikiforovAll
NikiforovAll requested changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@NikiforovAll NikiforovAll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, please review comments. Looking forwarding working with you on this one.

src/Keycloak.AuthServices.Sdk/Admin/Models/Group/Group.cs Outdated Show resolved Hide resolved
src/Keycloak.AuthServices.Sdk/Admin/IKeycloakGroupClient.cs Outdated Show resolved Hide resolved
src/Keycloak.AuthServices.Sdk/Admin/IKeycloakGroupClient.cs Outdated Show resolved Hide resolved
@sharwinbobde
Copy link
Contributor Author

@NikiforovAll, done, implemented and tested the changes

@NikiforovAll
Copy link
Owner

NikiforovAll commented Oct 25, 2023 •
edited
Loading

Thank you @sharwinbobde , LGTM

https://github.com/NikiforovAll/keycloak-authorization-services-dotnet/releases/tag/1.6.0

@NikiforovAll NikiforovAll merged commit 2062b24 into NikiforovAll:main Oct 25, 2023
8 checks passed
@sharwinbobde sharwinbobde mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikiforovAll NikiforovAll NikiforovAll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwinbobde @NikiforovAll