Make error response final #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Fingerprint.java:234: error: local variable errorResponse is accessed from within inner class; needs to be declared final
|
Thank your for this fix but since #179 is about to come out this won't be necessary. |
|
OK great! Thanks
… On 8 Nov 2019, at 17:20, Niklas Merz ***@***.***> wrote:
Thank your for this fix but since #179 <#179> is about to come out this won't be necessary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#203?email_source=notifications&email_token=ABUIQLKRXUJ74IWWFMP472TQSV7TLA5CNFSM4JKTNXU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDSNR6I#issuecomment-551868665>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUIQLIRCQIBL4AQRSII3B3QSV7TLANCNFSM4JKTNXUQ>.
|
|
Closed since #179 fixed this issue. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Fingerprint.java:234: error: local variable errorResponse is accessed from within inner class; needs to be declared final
Description
Prevent compile issues by making errorResponse final
How did you test your changes?
Compiled locally, no issues