-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds location id to order table #91
base: master
Are you sure you want to change the base?
Adds location id to order table #91
Conversation
In case of single store for all products (one location_id) will the code read from env and insert it if the one isn't provided as an input? |
No, it currently does not. There is an existing check for location_id during the charge process though: And since it's a required parameter for the setOrder function, it seems unlikely there would be many scenarios where locationId would not be available/passed through. |
There seems to be some errors with current tests, could you take a look and make a fix for it? |
@NikolaGavric94 Just to confirm - it looks like, outside of the syntax issues, every other error was getting thrown likely due to the fact that And in line 18 here references the namespace config: Are there any issues with the secrets in the github workflow file? This branch is passing locally for me when I run the same command in the main.yml file: |
Link to successful PHPUnit pipeline: https://github.com/Mrkbingham/laravel-square/pull/24/checks |
Not to be merged yet. I'll keep it approved for now |
Add location id to the order table
Since all Square orders (created using the Square facade) require a location ID to be added, storing that information will be useful for tracking orders on a per-store basis when integrating this library into other applications. The following changes apply here: