Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Create Reminder and Create Timeline functionality Integration Tests #54

Merged
merged 19 commits into from
Jan 22, 2025
Merged

Add Create Reminder and Create Timeline functionality Integration Tests #54

merged 19 commits into from
Jan 22, 2025

Conversation

HunorTotBagi
Copy link
Collaborator

@HunorTotBagi HunorTotBagi commented Jan 16, 2025 •
edited
Loading

In this PR I have:

  • Updated ReminderDto and TimelineDto class by specifying its JSON property names to facilitate use in tests
  • Updated the ReminderId and TimelineId value object by adding a dedicated JSON converter
  • Added Create Reminder and Timeline functionality integration tests

@HunorTotBagi HunorTotBagi added enhancement New feature or request backend Work performed on the backend solution labels Jan 16, 2025
@HunorTotBagi HunorTotBagi self-assigned this Jan 16, 2025
@HunorTotBagi HunorTotBagi linked an issue Jan 16, 2025 that may be closed by this pull request
Introduce Integration Test for the Create Reminder and Create Timeline Functionality (Happy Path Only) #47
Closed
@HunorTotBagi HunorTotBagi changed the title Added Create Reminder and Create Timeline functionality integration tests Add Create Reminder and Create Timeline functionality Integration Tests Jan 16, 2025
@HunorTotBagi HunorTotBagi marked this pull request as ready for review January 16, 2025 16:08
NikolaVetnic
NikolaVetnic approved these changes Jan 22, 2025
View reviewed changes
Copy link
Owner

@NikolaVetnic NikolaVetnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all this somewhat superficially. The tests work and pass, no problem there, but we will be getting rid of SpecFlow anyway so much of the test infrastructure will change... I.e. it's good for now.

Backend/src/Sdk/Core.Api.Sdk/CoreApiReminderClient.cs Outdated Show resolved Hide resolved
Backend/src/Sdk/Core.Api.Sdk/CoreApiTimelineClient.cs Outdated Show resolved Hide resolved
@HunorTotBagi HunorTotBagi merged commit 578aabd into main Jan 22, 2025
1 check passed
@HunorTotBagi HunorTotBagi deleted the jssbg-74_integration-tests-for-create-reminder-and-timelines branch January 22, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaVetnic NikolaVetnic NikolaVetnic approved these changes

Assignees

@HunorTotBagi HunorTotBagi

Labels
backend Work performed on the backend solution enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Integration Test for the Create Reminder and Create Timeline Functionality (Happy Path Only)
2 participants
@HunorTotBagi @NikolaVetnic